Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: chrome/browser/apps/guest_view/web_view_browsertest.cc

Issue 1934703002: Fix keyboard focus for OOPIF-<webview>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Fix tab focus change. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <queue> 5 #include <queue>
6 #include <utility> 6 #include <utility>
7 7
8 #include "base/location.h" 8 #include "base/location.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/path_service.h" 10 #include "base/path_service.h"
(...skipping 727 matching lines...) Expand 10 before | Expand all | Expand 10 after
738 738
739 class WebViewSizeTest : public WebViewTest {}; 739 class WebViewSizeTest : public WebViewTest {};
740 INSTANTIATE_TEST_CASE_P(WebViewTests, WebViewSizeTest, testing::Bool()); 740 INSTANTIATE_TEST_CASE_P(WebViewTests, WebViewSizeTest, testing::Bool());
741 741
742 class WebViewVisibilityTest : public WebViewTest {}; 742 class WebViewVisibilityTest : public WebViewTest {};
743 INSTANTIATE_TEST_CASE_P(WebViewTests, WebViewVisibilityTest, testing::Bool()); 743 INSTANTIATE_TEST_CASE_P(WebViewTests, WebViewVisibilityTest, testing::Bool());
744 744
745 class WebViewSpeechAPITest : public WebViewTest {}; 745 class WebViewSpeechAPITest : public WebViewTest {};
746 INSTANTIATE_TEST_CASE_P(WebViewTests, WebViewSpeechAPITest, testing::Bool()); 746 INSTANTIATE_TEST_CASE_P(WebViewTests, WebViewSpeechAPITest, testing::Bool());
747 747
748 // The following test suits are created to group tests based on specific 748 // The following test suites are created to group tests based on specific
749 // features of <webview>. 749 // features of <webview>.
750 // These features current would not work with 750 // These features currently would not work with
751 // --use-cross-process-frames-for-guest and is disabled on 751 // --use-cross-process-frames-for-guest and is disabled on
752 // UseCrossProcessFramesForGuests. 752 // UseCrossProcessFramesForGuests.
753 // TODO(avallee): https://crbug.com/610795
753 class WebViewAccessibilityTest : public WebViewTest {}; 754 class WebViewAccessibilityTest : public WebViewTest {};
754 INSTANTIATE_TEST_CASE_P(WebViewTests, 755 INSTANTIATE_TEST_CASE_P(WebViewTests,
755 WebViewAccessibilityTest, 756 WebViewAccessibilityTest,
756 testing::Values(false)); 757 testing::Values(false));
757 758
758 759
759 class WebViewDPITest : public WebViewTest { 760 class WebViewDPITest : public WebViewTest {
760 protected: 761 protected:
761 void SetUpCommandLine(base::CommandLine* command_line) override { 762 void SetUpCommandLine(base::CommandLine* command_line) override {
762 WebViewTest::SetUpCommandLine(command_line); 763 WebViewTest::SetUpCommandLine(command_line);
(...skipping 2228 matching lines...) Expand 10 before | Expand all | Expand 10 after
2991 gfx::Point embedder_origin = 2992 gfx::Point embedder_origin =
2992 GetEmbedderWebContents()->GetContainerBounds().origin(); 2993 GetEmbedderWebContents()->GetContainerBounds().origin();
2993 guest_rect.Offset(-embedder_origin.x(), -embedder_origin.y()); 2994 guest_rect.Offset(-embedder_origin.x(), -embedder_origin.y());
2994 2995
2995 // Generate and send synthetic touch event. 2996 // Generate and send synthetic touch event.
2996 content::SimulateTouchPressAt(GetEmbedderWebContents(), 2997 content::SimulateTouchPressAt(GetEmbedderWebContents(),
2997 guest_rect.CenterPoint()); 2998 guest_rect.CenterPoint());
2998 EXPECT_TRUE(aura_webview->HasFocus()); 2999 EXPECT_TRUE(aura_webview->HasFocus());
2999 } 3000 }
3000 #endif 3001 #endif
OLDNEW
« no previous file with comments | « no previous file | content/browser/frame_host/frame_tree.cc » ('j') | content/browser/frame_host/frame_tree.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698