Fix keyboard focus for OOPIF-<webview>.

content/browser/frame_host/render_widget_host_view_guest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_widget_host_view_guest.h"
 
 #include <utility>
 
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
@@ skipping 148 matching lines @@
 
 #if defined(USE_AURA)
 void RenderWidgetHostViewGuest::ProcessAckedTouchEvent(
     const TouchEventWithLatencyInfo& touch, InputEventAckState ack_result) {
   // TODO(tdresser): Since all ProcessAckedTouchEvent() uses is the event id,
   // don't pass the full event object here. https://crbug.com/550581.
   GetOwnerRenderWidgetHostView()->ProcessAckedTouchEvent(touch, ack_result);
 }
 #endif
 
+void RenderWidgetHostViewGuest::ProcessMouseEvent(
+    const blink::WebMouseEvent& event,
+    const ui::LatencyInfo& latency) {
+  if (event.type == blink::WebInputEvent::MouseDown) {
+    DCHECK(guest_->GetOwnerRenderWidgetHostView());
+    RenderWidgetHostImpl* embedder = static_cast<RenderWidgetHostImpl*>(

[alexmos, 2016/07/26 21:08:30]

Is this cast necessary?  Calling GetView()->HasFocus() and Focus() seems to be
possible directly on a RenderWidgetHost.

[avallee, 2016/07/27 01:30:18]

Done.

+        guest_->GetOwnerRenderWidgetHostView()->GetRenderWidgetHost());
+    if (!embedder->GetView()->HasFocus())
+      embedder->GetView()->Focus();
+
+    // TODO(wjmaclean): When we remove BrowserPlugin, delete this code.
+    // http://crbug.com/533069
+    MaybeSendSyntheticTapGesture(
+        blink::WebFloatPoint(event.x, event.y),
+        blink::WebFloatPoint(event.globalX, event.globalY));
+  }
+  host_->ForwardMouseEventWithLatencyInfo(event, latency);
+}
+
 void RenderWidgetHostViewGuest::ProcessTouchEvent(
     const blink::WebTouchEvent& event,
     const ui::LatencyInfo& latency) {
   if (event.type == blink::WebInputEvent::TouchStart) {
     DCHECK(guest_->GetOwnerRenderWidgetHostView());
     RenderWidgetHostImpl* embedder = static_cast<RenderWidgetHostImpl*>(
         guest_->GetOwnerRenderWidgetHostView()->GetRenderWidgetHost());
     if (!embedder->GetView()->HasFocus())
       embedder->GetView()->Focus();
 
-    // Since we now route GestureEvents directly to the guest renderer, we need
-    // a way to make sure that the BrowserPlugin in the embedder gets focused so
-    // that keyboard input (which still travels via BrowserPlugin) is routed to
-    // the plugin and thus onwards to the guest.

[wjmaclean, 2016/07/25 19:54:31]

Is it worth keeping some part of this comment around so readers know why
MaybeSendSyntheticTapGesture() exists? Possibly should be a one-liner at each
call site?

[avallee, 2016/07/26 20:11:51]

Done.

     // TODO(wjmaclean): When we remove BrowserPlugin, delete this code.
     // http://crbug.com/533069
-    if (!HasFocus()) {
-      // We need to a account for the position of the guest view within the
-      // embedder, as well as the fact that the embedder's host will add its
-      // offset in screen coordinates before sending the event (with the latter
-      // component just serving to confuse the renderer, hence why it should be
-      // removed).
-      gfx::Vector2d offset = GetViewBounds().origin() -
-          GetOwnerRenderWidgetHostView()->GetBoundsInRootWindow().origin();
-      blink::WebGestureEvent gesture_tap_event;
-      gesture_tap_event.sourceDevice = blink::WebGestureDeviceTouchscreen;
-      gesture_tap_event.type = blink::WebGestureEvent::GestureTapDown;
-      gesture_tap_event.x = event.touches[0].position.x + offset.x();
-      gesture_tap_event.y = event.touches[0].position.y + offset.y();
-      gesture_tap_event.globalX = event.touches[0].screenPosition.x;
-      gesture_tap_event.globalY = event.touches[0].screenPosition.y;
-      GetOwnerRenderWidgetHostView()->ProcessGestureEvent(gesture_tap_event,
-                                                          ui::LatencyInfo());
-      gesture_tap_event.type = blink::WebGestureEvent::GestureTapCancel;
-      GetOwnerRenderWidgetHostView()->ProcessGestureEvent(gesture_tap_event,
-                                                          ui::LatencyInfo());
-    }
+    MaybeSendSyntheticTapGesture(event.touches[0].position,
+                                 event.touches[0].screenPosition);
   }
 
   host_->ForwardTouchEventWithLatencyInfo(event, latency);
 }
 
 gfx::Rect RenderWidgetHostViewGuest::GetViewBounds() const {
   if (!guest_)
     return gfx::Rect();
 
   RenderWidgetHostViewBase* rwhv = GetOwnerRenderWidgetHostView();
@@ skipping 308 matching lines @@
 void RenderWidgetHostViewGuest::UnlockCompositingSurface() {
   NOTIMPLEMENTED();
 }
 
 RenderWidgetHostViewBase*
 RenderWidgetHostViewGuest::GetOwnerRenderWidgetHostView() const {
   return static_cast<RenderWidgetHostViewBase*>(
       guest_->GetOwnerRenderWidgetHostView());
 }
 
+// TODO(wjmaclean): When we remove BrowserPlugin, delete this code.
+// http://crbug.com/533069
+void RenderWidgetHostViewGuest::MaybeSendSyntheticTapGesture(
+    const blink::WebFloatPoint& position,
+    const blink::WebFloatPoint& screenPosition) const {
+  if (!HasFocus()) {
+    // We need to a account for the position of the guest view within the
+    // embedder, as well as the fact that the embedder's host will add its
+    // offset in screen coordinates before sending the event (with the latter
+    // component just serving to confuse the renderer, hence why it should be
+    // removed).
+    gfx::Vector2d offset =
+        GetViewBounds().origin() -
+        GetOwnerRenderWidgetHostView()->GetBoundsInRootWindow().origin();
+    blink::WebGestureEvent gesture_tap_event;
+    gesture_tap_event.sourceDevice = blink::WebGestureDeviceTouchscreen;
+    gesture_tap_event.type = blink::WebGestureEvent::GestureTapDown;
+    gesture_tap_event.x = position.x + offset.x();
+    gesture_tap_event.y = position.y + offset.y();
+    gesture_tap_event.globalX = screenPosition.x;
+    gesture_tap_event.globalY = screenPosition.y;
+    GetOwnerRenderWidgetHostView()->ProcessGestureEvent(gesture_tap_event,
+                                                        ui::LatencyInfo());
+    gesture_tap_event.type = blink::WebGestureEvent::GestureTapCancel;
+    GetOwnerRenderWidgetHostView()->ProcessGestureEvent(gesture_tap_event,
+                                                        ui::LatencyInfo());
+  }
+}
+
 void RenderWidgetHostViewGuest::WheelEventAck(
     const blink::WebMouseWheelEvent& event,
     InputEventAckState ack_result) {
   if (ack_result == INPUT_EVENT_ACK_STATE_NOT_CONSUMED ||
       ack_result == INPUT_EVENT_ACK_STATE_NO_CONSUMER_EXISTS) {
     guest_->ResendEventToEmbedder(event);
   }
 }
 
 void RenderWidgetHostViewGuest::GestureEventAck(
@@ skipping 94 matching lines @@
         gesture_event.data.scrollUpdate.inertialPhase ==
             blink::WebGestureEvent::MomentumPhase) {
       return;
     }
     host_->ForwardGestureEvent(gesture_event);
     return;
   }
 }
 
 }  // namespace content