content/browser/frame_host/render_frame_proxy_host.cc - Issue 1934703002: Fix keyboard focus for OOPIF-<webview>.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/frame_host/render_frame_proxy_host.cc

Issue 1934703002: Fix keyboard focus for OOPIF-<webview>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed test flakiness and comments in PS 7,8. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/test/data/extensions/platform_apps/web_view/focus/inject_focus.js ('K') | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/browser/site_per_process_browsertest.cc » ('j') | content/public/test/browser_test_utils.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "content/browser/frame_host/render_frame_proxy_host.h"	5 #include "content/browser/frame_host/render_frame_proxy_host.h"

6	6

7 #include <utility>	7 #include <utility>

8	8

9 #include "base/lazy_instance.h"	9 #include "base/lazy_instance.h"

10 #include "content/browser/bad_message.h"	10 #include "content/browser/bad_message.h"

(...skipping 352 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
363 ->GetRenderFrameProxyHost(target_rfh->GetSiteInstance());	363 ->GetRenderFrameProxyHost(target_rfh->GetSiteInstance());

364 if (source_proxy)	364 if (source_proxy)

365 source_proxy_routing_id = source_proxy->GetRoutingID();	365 source_proxy_routing_id = source_proxy->GetRoutingID();

366 }	366 }

367	367

368 target_rfh->Send(new FrameMsg_AdvanceFocus(target_rfh->GetRoutingID(), type,	368 target_rfh->Send(new FrameMsg_AdvanceFocus(target_rfh->GetRoutingID(), type,

369 source_proxy_routing_id));	369 source_proxy_routing_id));

370 }	370 }

371	371

372 void RenderFrameProxyHost::OnFrameFocused() {	372 void RenderFrameProxyHost::OnFrameFocused() {

373 frame_tree_node_->frame_tree()->SetFocusedFrame(frame_tree_node_,	373 frame_tree_node_->current_frame_host()->delegate()->SetFocusedFrame(

374 GetSiteInstance());	374 frame_tree_node_, GetSiteInstance());

375 }	375 }

376	376

377 } // namespace content	377 } // namespace content

OLD	NEW