Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: chrome/browser/apps/guest_view/web_view_browsertest.cc

Issue 1934703002: Fix keyboard focus for OOPIF-<webview>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed test flakiness and comments in PS 7,8. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <queue> 5 #include <queue>
6 #include <set> 6 #include <set>
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/callback_helpers.h" 9 #include "base/callback_helpers.h"
10 #include "base/files/file_util.h" 10 #include "base/files/file_util.h"
(...skipping 740 matching lines...) Expand 10 before | Expand all | Expand 10 after
751 751
752 class WebViewSizeTest : public WebViewTest {}; 752 class WebViewSizeTest : public WebViewTest {};
753 INSTANTIATE_TEST_CASE_P(WebViewTests, WebViewSizeTest, testing::Bool()); 753 INSTANTIATE_TEST_CASE_P(WebViewTests, WebViewSizeTest, testing::Bool());
754 754
755 class WebViewVisibilityTest : public WebViewTest {}; 755 class WebViewVisibilityTest : public WebViewTest {};
756 INSTANTIATE_TEST_CASE_P(WebViewTests, WebViewVisibilityTest, testing::Bool()); 756 INSTANTIATE_TEST_CASE_P(WebViewTests, WebViewVisibilityTest, testing::Bool());
757 757
758 class WebViewSpeechAPITest : public WebViewTest {}; 758 class WebViewSpeechAPITest : public WebViewTest {};
759 INSTANTIATE_TEST_CASE_P(WebViewTests, WebViewSpeechAPITest, testing::Bool()); 759 INSTANTIATE_TEST_CASE_P(WebViewTests, WebViewSpeechAPITest, testing::Bool());
760 760
761 // The following test suits are created to group tests based on specific 761 // The following test suites are created to group tests based on specific
762 // features of <webview>. 762 // features of <webview>.
763 // These features current would not work with 763 // These features currently would not work with
764 // --use-cross-process-frames-for-guest and is disabled on 764 // --use-cross-process-frames-for-guest and is disabled on
765 // UseCrossProcessFramesForGuests. 765 // UseCrossProcessFramesForGuests.
766 // TODO(avallee): https://crbug.com/610795: Enable this for testing::Bool().
766 class WebViewAccessibilityTest : public WebViewTest {}; 767 class WebViewAccessibilityTest : public WebViewTest {};
767 INSTANTIATE_TEST_CASE_P(WebViewTests, 768 INSTANTIATE_TEST_CASE_P(WebViewTests,
768 WebViewAccessibilityTest, 769 WebViewAccessibilityTest,
769 testing::Values(false)); 770 testing::Values(false));
770 771
771 772
772 class WebViewDPITest : public WebViewTest { 773 class WebViewDPITest : public WebViewTest {
773 protected: 774 protected:
774 void SetUpCommandLine(base::CommandLine* command_line) override { 775 void SetUpCommandLine(base::CommandLine* command_line) override {
775 WebViewTest::SetUpCommandLine(command_line); 776 WebViewTest::SetUpCommandLine(command_line);
(...skipping 2808 matching lines...) Expand 10 before | Expand all | Expand 10 after
3584 gfx::Point embedder_origin = 3585 gfx::Point embedder_origin =
3585 GetEmbedderWebContents()->GetContainerBounds().origin(); 3586 GetEmbedderWebContents()->GetContainerBounds().origin();
3586 guest_rect.Offset(-embedder_origin.x(), -embedder_origin.y()); 3587 guest_rect.Offset(-embedder_origin.x(), -embedder_origin.y());
3587 3588
3588 // Generate and send synthetic touch event. 3589 // Generate and send synthetic touch event.
3589 content::SimulateTouchPressAt(GetEmbedderWebContents(), 3590 content::SimulateTouchPressAt(GetEmbedderWebContents(),
3590 guest_rect.CenterPoint()); 3591 guest_rect.CenterPoint());
3591 EXPECT_TRUE(aura_webview->HasFocus()); 3592 EXPECT_TRUE(aura_webview->HasFocus());
3592 } 3593 }
3593 #endif 3594 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698