Fix keyboard focus for OOPIF-<webview>.

chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/location.h"
 #include "base/macros.h"
 #include "base/single_thread_task_runner.h"
 #include "base/strings/stringprintf.h"
@@ skipping 209 matching lines @@
   void TestHelper(const std::string& test_name,
                   const std::string& app_location,
                   TestServer test_server) {
     content::WebContents* embedder_web_contents = NULL;
     std::unique_ptr<ExtensionTestMessageListener> done_listener(RunAppHelper(
         test_name, app_location, test_server, &embedder_web_contents));
 
     ASSERT_TRUE(done_listener);
     ASSERT_TRUE(done_listener->WaitUntilSatisfied());
 
+    embedder_web_contents_ = embedder_web_contents;
     guest_web_contents_ = GetGuestViewManager()->WaitForSingleGuestCreated();
   }
 
   void SendMessageToEmbedder(const std::string& message) {
     ASSERT_TRUE(content::ExecuteScript(
         GetFirstAppWindowWebContents(),
         base::StringPrintf("onAppMessage('%s');", message.c_str())));
   }
 
   void SetupTest(const std::string& app_name,
@@ skipping 1098 matching lines @@
   // this time.
   for (size_t i = 0; i < 4; ++i)
     SendKeyPressToPlatformApp(ui::VKEY_TAB);
   ExtensionTestMessageListener webview_button_not_focused_listener(
       "WebViewInteractiveTest.WebViewButtonWasNotFocused", false);
   webview_button_not_focused_listener.set_failure_message(
       "WebViewInteractiveTest.WebViewButtonWasFocused");
   SendMessageToEmbedder("verify");
   EXPECT_TRUE(webview_button_not_focused_listener.WaitUntilSatisfied());
 }
+
+IN_PROC_BROWSER_TEST_P(WebViewInteractiveTest, KeyboardFocus) {
+  TestHelper("testKeyboardFocus", "web_view/focus", NO_TEST_SERVER);
+
+  EXPECT_EQ(embedder_web_contents()->GetFocusedFrame(),
+            embedder_web_contents()->GetMainFrame());
+  ExtensionTestMessageListener next_step_listener("TEST_STEP_PASSED", false);
+  next_step_listener.set_failure_message("TEST_STEP_FAILED");
+  {
+    content::SimulateMouseClickAt(embedder_web_contents(), 0,
+                                  blink::WebMouseEvent::ButtonLeft,
+                                  gfx::Point(40, 40));

[alexmos, 2016/06/07 22:03:43]

This expected to land on the <input> field created in the guest by createInput,
right?  (Might be good to note that in a comment.)  

Also, are we guaranteed to wait for the <input> to be created and visible before
this is dispatched, and that the coordinates won't change for some weird
platform?  (These have caused flakiness issues for similar tests in the past.)

[avallee, 2016/06/15 13:32:10]

1. Comment added.
2. Looking at it, I think you're right, this won't be synchronized. Added a
round trip in the javascript to release the test to this step once the input is
known to be in the DOM tree of the webview.

+  }
+  ASSERT_TRUE(next_step_listener.WaitUntilSatisfied());
+  if (GetParam()) {
+    EXPECT_NE(embedder_web_contents()->GetFocusedFrame(),

[alexmos, 2016/06/07 22:03:43]

embedder_web_contents()->GetFocusedFrame() should be null at this point, no? 
Can we just expect that?

[avallee, 2016/06/15 13:32:10]

Done.

+              embedder_web_contents()->GetMainFrame());
+  }
+
+  content::SimulateKeyPress(embedder_web_contents(), ui::VKEY_A, false, false,
+                            false, false);
+  content::SimulateKeyPress(embedder_web_contents(), ui::VKEY_B, false, false,
+                            false, false);
+  content::SimulateKeyPress(embedder_web_contents(), ui::VKEY_C, false, true,
+                            false, false);
+
+  next_step_listener.Reset();
+  EXPECT_TRUE(content::ExecuteScript(
+      embedder_web_contents(),
+      "window.runCommand('testKeyboardFocusRunNextStep', 'ABC');"));
+
+  ASSERT_TRUE(next_step_listener.WaitUntilSatisfied());
+}