sdk/lib/_internal/compiler/implementation/ssa/nodes.dart - Issue 19347002: Fix crash https://code.google.com/p/dart/issues/detail?id=11793: only compute a range for a loop if…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

Issue 19347002: Fix crash https://code.google.com/p/dart/issues/detail?id=11793: only compute a range for a loop if… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (revision 25009)

+++ sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (working copy)

@@ -620,6 +620,7 @@

* information on [to], and that dominates the user.

void rewriteWithBetterUser(HInstruction from, HInstruction to) {

+ // BUG(11841): Turn this method into a phase to be run after GVN phases.

Link<HCheck> better = const Link<HCheck>();

for (HInstruction user in to.usedBy) {

if (user == from || user is! HCheck) continue;

« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart » ('j') | no next file with comments »