Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioParam.h

Issue 1934683002: Add histograms for Biquad lowpass and highpass Q values (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove variables used only once. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webaudio/AudioParam.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/webaudio/AudioParam.h
diff --git a/third_party/WebKit/Source/modules/webaudio/AudioParam.h b/third_party/WebKit/Source/modules/webaudio/AudioParam.h
index dd000e52002d243411e779fa44af09c838e23993..86551572b463f1bb6846c99b2ae50d6407a5465e 100644
--- a/third_party/WebKit/Source/modules/webaudio/AudioParam.h
+++ b/third_party/WebKit/Source/modules/webaudio/AudioParam.h
@@ -51,6 +51,8 @@ enum AudioParamType {
ParamTypeAudioBufferSourceDetune,
ParamTypeBiquadFilterFrequency,
ParamTypeBiquadFilterQ,
+ ParamTypeBiquadFilterQLowpass,
+ ParamTypeBiquadFilterQHighpass,
ParamTypeBiquadFilterGain,
ParamTypeBiquadFilterDetune,
ParamTypeDelayDelayTime,
@@ -75,6 +77,7 @@ enum AudioParamType {
class AudioParamHandler final : public ThreadSafeRefCounted<AudioParamHandler>, public AudioSummingJunction {
public:
AudioParamType getParamType() const { return m_paramType; }
+ void setParamType(AudioParamType);
// Return a nice name for the AudioParam.
String getParamName() const;
@@ -127,6 +130,10 @@ public:
void disconnect(AudioNodeOutput&);
float intrinsicValue() const { return noBarrierLoad(&m_intrinsicValue); }
+
+ // Update any histograms with the given value.
+ void updateHistograms(float newValue);
+
private:
AudioParamHandler(AbstractAudioContext&, AudioParamType, double defaultValue);
@@ -134,6 +141,8 @@ private:
void calculateFinalValues(float* values, unsigned numberOfValues, bool sampleAccurate);
void calculateTimelineValues(float* values, unsigned numberOfValues);
+ int computeQHistogramValue(float) const;
+
// The type of AudioParam, indicating what this AudioParam represents and what node it belongs
// to. Mostly for informational purposes and doesn't affect implementation.
AudioParamType m_paramType;
@@ -165,6 +174,7 @@ public:
AbstractAudioContext* context() const { return m_context; }
AudioParamType getParamType() const { return handler().getParamType(); }
+ void setParamType(AudioParamType);
String getParamName() const;
float value() const;
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webaudio/AudioParam.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698