Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1934633002:
Avoid reliance on undefined malloc(0) behavior. (Closed)
|
Created:
4 years, 7 months ago by MTBrandyberry Modified:
4 years, 7 months ago CC:
v8-reviews_googlegroups.com, michael_dawson, JaideepBajwa Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionAvoid reliance on undefined malloc(0) behavior.
AIX returns NULL rather than a valid heap address.
TEST=cctest/test-run-wasm-module/Run_WasmModule_CallAdd_rev
R=titzer@chromium.org, jochen@chromium.org
BUG=
Committed: https://crrev.com/791c0400cfbbfbd64a95f7da6379bf15e5cbc285
Cr-Commit-Position: refs/heads/master@{#35913}
Patch Set 1 #
Messages
Total messages: 18 (9 generated)
Description was changed from ========== Avoid reliance on undefined malloc(0) behavior. AIX returns NULL rather than a valid heap address. TEST=cctest/test-run-wasm-module/Run_WasmModule_CallAdd_rev R=titzer@chromium.org, jochen@chromium.org BUG= ========== to ========== Avoid reliance on undefined malloc(0) behavior. AIX returns NULL rather than a valid heap address. TEST=cctest/test-run-wasm-module/Run_WasmModule_CallAdd_rev R=titzer@chromium.org, jochen@chromium.org BUG= ==========
PTAL
The CQ bit was checked by mbrandy@us.ibm.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934633002/1
The CQ bit was unchecked by commit-bot@chromium.org
The CQ bit was unchecked by mbrandy@us.ibm.com
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-v8-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by mbrandy@us.ibm.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934633002/1
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mbrandy@us.ibm.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934633002/1
Message was sent while issue was closed.
Description was changed from ========== Avoid reliance on undefined malloc(0) behavior. AIX returns NULL rather than a valid heap address. TEST=cctest/test-run-wasm-module/Run_WasmModule_CallAdd_rev R=titzer@chromium.org, jochen@chromium.org BUG= ========== to ========== Avoid reliance on undefined malloc(0) behavior. AIX returns NULL rather than a valid heap address. TEST=cctest/test-run-wasm-module/Run_WasmModule_CallAdd_rev R=titzer@chromium.org, jochen@chromium.org BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Avoid reliance on undefined malloc(0) behavior. AIX returns NULL rather than a valid heap address. TEST=cctest/test-run-wasm-module/Run_WasmModule_CallAdd_rev R=titzer@chromium.org, jochen@chromium.org BUG= ========== to ========== Avoid reliance on undefined malloc(0) behavior. AIX returns NULL rather than a valid heap address. TEST=cctest/test-run-wasm-module/Run_WasmModule_CallAdd_rev R=titzer@chromium.org, jochen@chromium.org BUG= Committed: https://crrev.com/791c0400cfbbfbd64a95f7da6379bf15e5cbc285 Cr-Commit-Position: refs/heads/master@{#35913} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/791c0400cfbbfbd64a95f7da6379bf15e5cbc285 Cr-Commit-Position: refs/heads/master@{#35913} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
