Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1934623002: Revert of patch suspect of causing Android GPU builds to start failing (Closed)

Created:
4 years, 7 months ago by ccameron
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, nyquist+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, ben+mojo_chromium.org, cbentzel+watch_chromium.org, maniscalco+watch-blimp_chromium.org, chromoting-reviews_chromium.org, jam, abarth-chromium, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, darin-cc_chromium.org, jbudorick+watch_chromium.org, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, android-webview-reviews_chromium.org, Aaron Boodman, mikecase+watch_chromium.org, darin (slow to review), dtrainor+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of patch suspect of causing Android GPU builds to start failing In particular android_webview_webgl_conformance_tests Patch to remove is https://codereview.chromium.org/1930443003/ This does not revert cleanly unless two more patches on top are taken out as well (sorry). Revert "Reland of Unify application context usage." This reverts commit 374f8aaa937881f494a65a76e55e25375860535f. Revert "[Cronet] Avoid crashing when CronetEngines are created on multiple threads" This reverts commit 315ed9b17216bff1847dce29ecae62828e09ead8. Revert "Ensure that PathUtils is initialized correctly." This reverts commit 967c8e24618a2de25b9d8994f752c3f79360667d. BUG= TBR=torne@chromium.org,davidben@chromium.org,yfriedman@chromium.org,nyquist@chromium.org,caitkp@chromium.org,sergeyu@chromium.org,amistry@chromium.org,wnwen Committed: https://crrev.com/9983450a363de801627e58040ec8cf78fbe37642 Cr-Commit-Position: refs/heads/master@{#390681}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -155 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java View 7 chunks +19 lines, -8 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java View 4 chunks +5 lines, -9 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerStartupTest.java View 2 chunks +2 lines, -4 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/HttpCacheTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/test/AwTestRunnerActivity.java View 2 chunks +0 lines, -2 lines 0 comments Download
M base/android/context_utils.h View 1 chunk +8 lines, -0 lines 0 comments Download
M base/android/context_utils.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M base/android/java/src/org/chromium/base/ContextUtils.java View 3 chunks +13 lines, -31 lines 0 comments Download
M base/android/java/src/org/chromium/base/PathUtils.java View 3 chunks +8 lines, -14 lines 0 comments Download
M base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java View 4 chunks +11 lines, -8 lines 0 comments Download
M blimp/client/app/android/java/src/org/chromium/blimp/BlimpLibraryLoader.java View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java View 3 chunks +2 lines, -4 lines 0 comments Download
M components/cronet/android/java/src/org/chromium/net/CronetLibraryLoader.java View 4 chunks +11 lines, -24 lines 0 comments Download
M components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java View 2 chunks +1 line, -2 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java View 1 chunk +0 lines, -26 lines 0 comments Download
M components/resource_provider/android/android_hooks.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/resource_provider/android/java/org/chromium/resource_provider/Main.java View 2 chunks +0 lines, -2 lines 0 comments Download
M components/web_restrictions/browser/junit/src/org/chromium/components/webrestrictions/WebRestrictionsClientTest.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/app/ChildProcessService.java View 2 chunks +1 line, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/BrowserStartupController.java View 3 chunks +4 lines, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java View 1 chunk +1 line, -1 line 0 comments Download
M mojo/android/javatests/src/org/chromium/mojo/MojoTestCase.java View 2 chunks +3 lines, -4 lines 0 comments Download
M net/android/junit/src/org/chromium/net/HttpNegotiateAuthenticatorTest.java View 1 chunk +1 line, -1 line 0 comments Download
M remoting/android/host/src/org/chromium/chromoting/host/jni/Host.java View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java View 1 chunk +2 lines, -2 lines 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/NativeUnitTestActivity.java View 3 chunks +0 lines, -3 lines 0 comments Download
M testing/android/native_test/native_test_launcher.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934623002/1
4 years, 7 months ago (2016-04-29 16:32:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 17:22:56 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:26:42 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9983450a363de801627e58040ec8cf78fbe37642
Cr-Commit-Position: refs/heads/master@{#390681}

Powered by Google App Engine
This is Rietveld 408576698