Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 1934583002: PopularSites: don't wait for a SuggestionsService network request (Closed)

Created:
4 years, 7 months ago by Marc Treib
Modified:
4 years, 7 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, sfiera
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PopularSites: don't wait for a SuggestionsService network request BUG=607615 Committed: https://crrev.com/c1bd1f1093db2d9aada0cb4dd02c95c80f48ea55 Cr-Commit-Position: refs/heads/master@{#390648}

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -25 lines) Patch
M chrome/browser/android/ntp/most_visited_sites.h View 2 chunks +4 lines, -4 lines 2 comments Download
M chrome/browser/android/ntp/most_visited_sites.cc View 8 chunks +17 lines, -21 lines 3 comments Download

Messages

Total messages: 9 (3 generated)
Marc Treib
PTAL! https://codereview.chromium.org/1934583002/diff/1/chrome/browser/android/ntp/most_visited_sites.cc File chrome/browser/android/ntp/most_visited_sites.cc (left): https://codereview.chromium.org/1934583002/diff/1/chrome/browser/android/ntp/most_visited_sites.cc#oldcode365 chrome/browser/android/ntp/most_visited_sites.cc:365: return; This was the actual problem - we'd ...
4 years, 7 months ago (2016-04-29 13:58:33 UTC) #2
Bernhard Bauer
lgtm https://codereview.chromium.org/1934583002/diff/1/chrome/browser/android/ntp/most_visited_sites.h File chrome/browser/android/ntp/most_visited_sites.h (right): https://codereview.chromium.org/1934583002/diff/1/chrome/browser/android/ntp/most_visited_sites.h#newcode93 chrome/browser/android/ntp/most_visited_sites.h:93: // must not be null. From a general ...
4 years, 7 months ago (2016-04-29 14:15:31 UTC) #3
Marc Treib
Thanks! https://codereview.chromium.org/1934583002/diff/1/chrome/browser/android/ntp/most_visited_sites.h File chrome/browser/android/ntp/most_visited_sites.h (right): https://codereview.chromium.org/1934583002/diff/1/chrome/browser/android/ntp/most_visited_sites.h#newcode93 chrome/browser/android/ntp/most_visited_sites.h:93: // must not be null. On 2016/04/29 14:15:31, ...
4 years, 7 months ago (2016-04-29 14:18:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934583002/1
4 years, 7 months ago (2016-04-29 14:19:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 15:06:14 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:25:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1bd1f1093db2d9aada0cb4dd02c95c80f48ea55
Cr-Commit-Position: refs/heads/master@{#390648}

Powered by Google App Engine
This is Rietveld 408576698