Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1934563002: [compiler] Fix TurboFan to respect kOptimizeFromBytecode. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Fix TurboFan to respect kOptimizeFromBytecode. This ensures that the TurboFan pipeline is respecting the flag on the CompilationInfo controlling whether to use the BytecodeGraphBuilder or the AstGraphBuilder when ensuring deoptimization support. R=rmcilroy@chromium.org BUG=chromium:607871 LOG=n Committed: https://crrev.com/5749d710bc73ef40f9b9e8b94ec290e0412d3f57 Cr-Commit-Position: refs/heads/master@{#35904}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Starzinger
4 years, 7 months ago (2016-04-29 11:42:51 UTC) #3
rmcilroy
Lgtm, thanks. As discussed, could you also set the new flag on test-run-bytecode-graph-builder as discussed ...
4 years, 7 months ago (2016-04-29 11:48:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934563002/1
4 years, 7 months ago (2016-04-29 12:00:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 12:04:23 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:03:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5749d710bc73ef40f9b9e8b94ec290e0412d3f57
Cr-Commit-Position: refs/heads/master@{#35904}

Powered by Google App Engine
This is Rietveld 408576698