Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1934473002: 👕 Fix android lint warning in TokenSourceImpl.java (Closed)

Created:
4 years, 7 months ago by agrieve
Modified:
4 years, 7 months ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix android lint warning in TokenSourceImpl.java Consider using `apply()` instead; `commit` writes its data to persistent storage immediately, whereas `apply` will handle it in the background: CommitPrefEdits [warning] BUG=607761 Committed: https://crrev.com/6b9957478bb09c311650460b568f237f45c7db8c Cr-Commit-Position: refs/heads/master@{#390563}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M blimp/client/app/android/java/src/org/chromium/blimp/auth/TokenSourceImpl.java View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
agrieve
4 years, 7 months ago (2016-04-29 00:37:15 UTC) #2
nyquist
Thanks, and lgtm.
4 years, 7 months ago (2016-04-29 01:04:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934473002/1
4 years, 7 months ago (2016-04-29 01:07:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 01:44:06 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:23:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b9957478bb09c311650460b568f237f45c7db8c
Cr-Commit-Position: refs/heads/master@{#390563}

Powered by Google App Engine
This is Rietveld 408576698