Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: src/log.cc

Issue 1934453003: [prof] export slide offset in profile log (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/log.cc
diff --git a/src/log.cc b/src/log.cc
index 3abf442d7f5ad50c2bbba43356b4c069e95c2005..a3d09b6f84c37f041bb3c40cae5e10e6ddf126ae 100644
--- a/src/log.cc
+++ b/src/log.cc
@@ -666,7 +666,8 @@ void Profiler::Engage() {
base::OS::GetSharedLibraryAddresses();
for (size_t i = 0; i < addresses.size(); ++i) {
LOG(isolate_, SharedLibraryEvent(
- addresses[i].library_path, addresses[i].start, addresses[i].end));
+ addresses[i].library_path, addresses[i].start, addresses[i].end,
+ addresses[i].slide));
}
// Start thread processing the profiler buffer.
@@ -828,11 +829,13 @@ void Logger::ApiSecurityCheck() {
void Logger::SharedLibraryEvent(const std::string& library_path,
uintptr_t start,
- uintptr_t end) {
+ uintptr_t end,
+ uintptr_t slide) {
if (!log_->IsEnabled() || !FLAG_prof_cpp) return;
Log::MessageBuilder msg(log_);
- msg.Append("shared-library,\"%s\",0x%08" V8PRIxPTR ",0x%08" V8PRIxPTR,
- library_path.c_str(), start, end);
+ msg.Append("shared-library,\"%s\",0x%08" V8PRIxPTR ",0x%08" V8PRIxPTR
+ ",0x%08" V8PRIxPTR,
+ library_path.c_str(), start, end, slide);
msg.WriteToLogFile();
}

Powered by Google App Engine
This is Rietveld 408576698