[prof] export slide offset in profile log

src/base/platform/platform.h

Index: src/base/platform/platform.h
diff --git a/src/base/platform/platform.h b/src/base/platform/platform.h
index 84d9db5b9356a34a050e2f92edf07d97699cbb03..9dbca385d087ccbba5f02f2d4b6a8eb3ac3c239f 100644
--- a/src/base/platform/platform.h
+++ b/src/base/platform/platform.h
@@ -237,11 +237,16 @@ class OS {
   struct SharedLibraryAddress {
     SharedLibraryAddress(
         const std::string& library_path, uintptr_t start, uintptr_t end)
-        : library_path(library_path), start(start), end(end) {}
+        : library_path(library_path), start(start), end(end), slide(0) {}
+    SharedLibraryAddress(
+        const std::string& library_path, uintptr_t start, uintptr_t end,
+            uintptr_t slide)
+        : library_path(library_path), start(start), end(end), slide(slide) {}

[noordhuis, 2016/04/30 10:37:10]

I think this should use intptr_t for the slide because it can be negative; text
sections can be mapped before their default load addresses.  Because of
signed-to-unsigned conversion, logging such slides and adding them to function
addresses in tickprocessor.js, produces bogus results.

intptr_t is what _dyld_get_image_vmaddr_slide() returns.  platform-macos.cc
currently gets this wrong, FWIW.

[fedor.indutny, 2016/04/30 19:54:50]

Acknowledged.

 
     std::string library_path;
     uintptr_t start;
     uintptr_t end;
+    uintptr_t slide;
   };
 
   static std::vector<SharedLibraryAddress> GetSharedLibraryAddresses();