Add chromiumos_preflight build target

Add chromiumos_preflight build target

BUG=433082
Committed: https://crrev.com/d570b1f16e30edb5b6b7254c9549d1355fe1cd03
Cr-Commit-Position: refs/heads/master@{#390793}

[stevenjb, 2016-04-28 23:27:58]

stevenjb@chromium.org changed reviewers:
+ dpranke@chromium.org, hashimoto@chromium.org

[stevenjb, 2016-04-28 23:27:59]

This works locally for me with the dependent CL.

I used:

      "//chrome/test/chromedriver:chromedriver",
      "//chrome/test/chromedriver:chromedriver_unittests",

Instead of:

      "//chrome/test/chromedriver",

Because I was getting the following with just chroemdriver:

ninja: Entering directory `out/Release'
[1/1] Regenerating ninja files
FAILED: build.ninja 
/usr/local/google/home/stevenjb/Work/chrome/src/buildtools/linux64/gn
--root=/usr/local/google/home/stevenjb/Work/chrome/src -q gen //out/Release/
ERROR Unresolved dependencies.
//:chromiumos_preflight(//build/toolchain/cros:clang_target)
  needs //chrome/test:chromedriver(//build/toolchain/cros:clang_target)

Thoughts / suggestions?

[Dirk Pranke, 2016-04-28 23:50:57]

On 2016/04/28 23:27:59, stevenjb wrote:
> This works locally for me with the dependent CL.
> 
> I used:
> 
>       "//chrome/test/chromedriver:chromedriver",
>       "//chrome/test/chromedriver:chromedriver_unittests",
> 
> Instead of:
> 
>       "//chrome/test/chromedriver",
> 
> Because I was getting the following with just chroemdriver:
> 
> ninja: Entering directory `out/Release'
> [1/1] Regenerating ninja files
> FAILED: build.ninja 
> /usr/local/google/home/stevenjb/Work/chrome/src/buildtools/linux64/gn
> --root=/usr/local/google/home/stevenjb/Work/chrome/src -q gen //out/Release/
> ERROR Unresolved dependencies.
> //:chromiumos_preflight(//build/toolchain/cros:clang_target)
>   needs //chrome/test:chromedriver(//build/toolchain/cros:clang_target)

I suspect you had a typo somewhere (notice how that says "needs
//chrome/test:chromedriver",
not "//chrome/test/chromedriver" ?

The latter works for me.

[Dirk Pranke, 2016-04-28 23:52:19]

https://codereview.chromium.org/1934443002/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1934443002/diff/1/BUILD.gn#newcode111
BUILD.gn:111: }
You don't need the mesa or nacl_helper lines, since they'll be pulled in
automatically and built by chrome. GN style for top-level groups like this is to
only list the minimal set of targets needed.

[Dirk Pranke, 2016-04-28 23:52:30]

lgtm w/ my comments addressed.

[stevenjb, 2016-04-29 20:30:06]

https://codereview.chromium.org/1934443002/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1934443002/diff/1/BUILD.gn#newcode111
BUILD.gn:111: }
On 2016/04/28 23:52:19, Dirk Pranke wrote:
> You don't need the mesa or nacl_helper lines, since they'll be pulled in
> automatically and built by chrome. GN style for top-level groups like this is
to
> only list the minimal set of targets needed.

Done.

[stevenjb, 2016-04-29 21:44:45]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2016-04-29 21:44:45]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1934443002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2016-04-29 21:45:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1934443002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1934443002/20001

[commit-bot: I haz the power, 2016-04-29 22:57:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-30 17:29:51]

Patchset 2 (id:??) landed as
https://crrev.com/d570b1f16e30edb5b6b7254c9549d1355fe1cd03
Cr-Commit-Position: refs/heads/master@{#390793}

[commit-bot: I haz the power, 2016-04-30 18:03:20]

Description was changed from

==========
Add chromiumos_preflight build target

BUG=433082
==========

to

==========
Add chromiumos_preflight build target

BUG=433082

Committed: https://crrev.com/d570b1f16e30edb5b6b7254c9549d1355fe1cd03
Cr-Commit-Position: refs/heads/master@{#390793}
==========