Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1991)

Issue 193443004: Undeprecate DocumentClear, CaptureEvents and ReleaseEvents (Closed)

Created:
6 years, 9 months ago by philipj_slow
Modified:
6 years, 9 months ago
CC:
blink-reviews, adamk+blink_chromium.org, dglazkov+blink, arv+blink, Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Undeprecate DocumentClear, CaptureEvents and ReleaseEvents These are all specified for Document: http://www.whatwg.org/specs/web-apps/current-work/multipage/obsolete.html#obsolete There's no spec for Window, so split the CaptureEvents and ReleaseEvents counters. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169054

Patch Set 1 #

Patch Set 2 : update test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -29 lines) Patch
M LayoutTests/fast/dom/HTMLDocument/capture-events-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/HTMLDocument/release-events-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/capture-events-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/release-events-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/document-clear-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 2 chunks +0 lines, -9 lines 0 comments Download
M Source/core/frame/Window.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLDocument.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDocument.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/html/HTMLDocument.idl View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
philipj_slow
6 years, 9 months ago (2014-03-11 04:12:27 UTC) #1
eseidel
I think it's actually good to warn authors here. Empty methods just cause confusion. Eventually ...
6 years, 9 months ago (2014-03-11 04:35:34 UTC) #2
philipj_slow
On 2014/03/11 04:35:34, eseidel wrote: > I think it's actually good to warn authors here. ...
6 years, 9 months ago (2014-03-11 06:55:33 UTC) #3
philipj_slow
PTAL, blink-dev thread has wound down.
6 years, 9 months ago (2014-03-12 16:49:05 UTC) #4
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-12 19:33:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/193443004/20001
6 years, 9 months ago (2014-03-12 19:36:07 UTC) #6
commit-bot: I haz the power
Change committed as 169054
6 years, 9 months ago (2014-03-12 19:49:47 UTC) #7
philipj_slow
6 years, 9 months ago (2014-03-17 08:10:22 UTC) #8
Message was sent while issue was closed.
"There's no spec for Window, so split the CaptureEvents and ReleaseEvents
counters."

I thought I had grepped the spec source properly to confirm this, but now I see
that this was a lie:
http://www.whatwg.org/specs/web-apps/current-work/multipage/obsolete.html#Win...

No harm in counting them separately I guess, but let's hope no one reads the
commit message too carefullly...

Powered by Google App Engine
This is Rietveld 408576698