Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1375)

Issue 1934423002: [NOT FOR REVIEW] [reland] Browser Side Text Input State Tracking for OOPIF (Aura Only) (Closed)

Created:
4 years, 7 months ago by EhsanK
Modified:
4 years, 1 month ago
Reviewers:
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[reland] Browser Side Text Input State Tracking for OOPIF (Aura Only) This CL relands the original issue https://codereview.chromium.org/1652483002/, with modifications and for aura only (Linux, Windows). The new design is based on RenderWidgetHostViewObserver which will fix some of the lifetime management issues in the original CL that caused DCHECK and crashes. This CL will introduce a TextInputManager class which is owned by the outermost WebContentsImpl and tracks the TextInputState from all RWHV belonging to WebContentsImpl itself or any of the inner WebContents inside. TextInputManager is accessed by the RWHVs to set or obtain TextInputState for the tab. This CL also adds multiple tests for TextInputState tracking and IME. BUG=578168, 602723 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Patch Set 2 : Rebase/Merge and Added One Last Test #

Patch Set 3 : More Fixes #

Patch Set 4 : Fixed more Compile Errors #

Patch Set 5 : Fixed another Compile Error #

Patch Set 6 : Fix another Compile Error #

Patch Set 7 : Probably fixed the compile error #

Patch Set 8 : Fixed some more errors #

Patch Set 9 : Fixed Some More Errors #

Patch Set 10 : Fixed yet Another #

Patch Set 11 : Fixed initialization order #

Patch Set 12 : #

Patch Set 13 : Using initializer_list #

Patch Set 14 : Removed Local Memeber in Aura #

Patch Set 15 : Properly Initialzie text_input_manager_ #

Patch Set 16 : Enhancing code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1233 lines, -49 lines) Patch
M chrome/browser/site_per_process_interactive_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +461 lines, -0 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.h View 3 chunks +4 lines, -0 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +15 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_delegate.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +6 lines, -9 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 6 chunks +35 lines, -28 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 7 chunks +21 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 2 3 4 5 6 7 4 chunks +31 lines, -0 lines 0 comments Download
A content/browser/renderer_host/text_input_manager.h View 1 2 3 4 5 6 7 8 1 chunk +89 lines, -0 lines 0 comments Download
A content/browser/renderer_host/text_input_manager.cc View 1 2 3 4 5 6 7 8 1 chunk +114 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 3 chunks +4 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +17 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A content/public/test/text_input_test_utils.h View 1 2 3 4 5 6 7 8 9 1 chunk +104 lines, -0 lines 0 comments Download
A content/public/test/text_input_test_utils.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +320 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (2 generated)
EhsanK
Description was changed from ========== [reland] Browser Side Text Input State Tracking for OOPIF (Aura ...
4 years, 7 months ago (2016-05-02 17:16:46 UTC) #1
EhsanK
4 years, 7 months ago (2016-05-05 14:22:20 UTC) #2
Description was changed from

==========
[reland] Browser Side Text Input State Tracking for OOPIF (Aura Only)

This CL relands the original issue https://codereview.chromium.org/1652483002/,
with modifications and for aura only (Linux, Windows). The new design is based
on RenderWidgetHostViewObserver which will fix some of the lifetime management
issues in the original CL that caused DCHECK and crashes.

This CL will introduce a TextInputManager class which is owned by the outermost
WebContentsImpl and tracks the TextInputState from all RWHV belonging to
WebContentsImpl itself or any of the inner WebContents inside. TextInputManager
is accessed by the RWHVs to set or obtain TextInputState for the tab.

This CL also adds multiple tests for TextInputState tracking and IME.

BUG=578168, 602723
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
[reland] Browser Side Text Input State Tracking for OOPIF (Aura Only)

This CL relands the original issue https://codereview.chromium.org/1652483002/,
with modifications and for aura only (Linux, Windows). The new design is based
on RenderWidgetHostViewObserver which will fix some of the lifetime management
issues in the original CL that caused DCHECK and crashes.

This CL will introduce a TextInputManager class which is owned by the outermost
WebContentsImpl and tracks the TextInputState from all RWHV belonging to
WebContentsImpl itself or any of the inner WebContents inside. TextInputManager
is accessed by the RWHVs to set or obtain TextInputState for the tab.

This CL also adds multiple tests for TextInputState tracking and IME.

BUG=578168, 602723
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

Powered by Google App Engine
This is Rietveld 408576698