Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1934413003: Usecounter added for counting usage of addEventListener for PointerEvents. (Closed)

Created:
4 years, 7 months ago by sahel
Modified:
4 years, 7 months ago
CC:
chromium-reviews, blink-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Usecounter added for counting usage of addEventListener for PointerEvents. BUG=605244 TEST=~/chromium/src/third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/pointer-add-event-listener-count.html Committed: https://crrev.com/db9ccdad371b96fa9b30e2fa88dcc8fc6b1bf472 Cr-Commit-Position: refs/heads/master@{#393103}

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : #

Total comments: 5

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Messages

Total messages: 29 (10 generated)
mustaq
https://codereview.chromium.org/1934413003/diff/1/third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/pointer-add-event-listener-count.html File third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/pointer-add-event-listener-count.html (right): https://codereview.chromium.org/1934413003/diff/1/third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/pointer-add-event-listener-count.html#newcode1 third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/pointer-add-event-listener-count.html:1: <!DOCTYPE HTML> Could we please add the new test ...
4 years, 7 months ago (2016-05-03 14:33:29 UTC) #3
mustaq
https://codereview.chromium.org/1934413003/diff/1/third_party/WebKit/Source/core/events/EventTarget.cpp File third_party/WebKit/Source/core/events/EventTarget.cpp (right): https://codereview.chromium.org/1934413003/diff/1/third_party/WebKit/Source/core/events/EventTarget.cpp#newcode153 third_party/WebKit/Source/core/events/EventTarget.cpp:153: return addEventListenerInternal(eventType, listener, options); - Check if it is ...
4 years, 7 months ago (2016-05-03 14:40:22 UTC) #4
tdresser
Yeah, everything looks good, except that we might as well test this use counter in ...
4 years, 7 months ago (2016-05-03 14:41:01 UTC) #5
tdresser
https://codereview.chromium.org/1934413003/diff/1/third_party/WebKit/Source/core/events/EventTarget.cpp File third_party/WebKit/Source/core/events/EventTarget.cpp (right): https://codereview.chromium.org/1934413003/diff/1/third_party/WebKit/Source/core/events/EventTarget.cpp#newcode153 third_party/WebKit/Source/core/events/EventTarget.cpp:153: return addEventListenerInternal(eventType, listener, options); On 2016/05/03 14:40:22, mustaq wrote: ...
4 years, 7 months ago (2016-05-03 16:13:47 UTC) #6
mustaq
On 2016/05/03 16:13:47, tdresser wrote: > https://codereview.chromium.org/1934413003/diff/1/third_party/WebKit/Source/core/events/EventTarget.cpp > File third_party/WebKit/Source/core/events/EventTarget.cpp (right): > > https://codereview.chromium.org/1934413003/diff/1/third_party/WebKit/Source/core/events/EventTarget.cpp#newcode153 > ...
4 years, 7 months ago (2016-05-03 17:34:53 UTC) #7
tdresser
On 2016/05/03 17:34:53, mustaq wrote: > On 2016/05/03 16:13:47, tdresser wrote: > > > https://codereview.chromium.org/1934413003/diff/1/third_party/WebKit/Source/core/events/EventTarget.cpp ...
4 years, 7 months ago (2016-05-03 18:12:47 UTC) #8
sahel
I forgot to click on publish+mail on set 2 and had to update the number ...
4 years, 7 months ago (2016-05-06 16:35:45 UTC) #9
tdresser
LGTM
4 years, 7 months ago (2016-05-06 16:38:37 UTC) #10
mustaq
lgtm
4 years, 7 months ago (2016-05-06 16:59:24 UTC) #11
Alexei Svitkine (slow)
lgtm
4 years, 7 months ago (2016-05-09 21:05:55 UTC) #14
bokan
https://codereview.chromium.org/1934413003/diff/40001/third_party/WebKit/Source/core/events/EventTarget.cpp File third_party/WebKit/Source/core/events/EventTarget.cpp (right): https://codereview.chromium.org/1934413003/diff/40001/third_party/WebKit/Source/core/events/EventTarget.cpp#newcode156 third_party/WebKit/Source/core/events/EventTarget.cpp:156: if (EventUtil::isPointerEventType(eventType)) { Put this in the addedEventListener method ...
4 years, 7 months ago (2016-05-10 22:52:02 UTC) #15
sahel
I had to update the enum number in UseCounter.h https://codereview.chromium.org/1934413003/diff/40001/third_party/WebKit/Source/core/events/EventTarget.cpp File third_party/WebKit/Source/core/events/EventTarget.cpp (right): https://codereview.chromium.org/1934413003/diff/40001/third_party/WebKit/Source/core/events/EventTarget.cpp#newcode156 third_party/WebKit/Source/core/events/EventTarget.cpp:156: ...
4 years, 7 months ago (2016-05-11 21:15:02 UTC) #16
bokan
lgtm module namespace naming issue. https://codereview.chromium.org/1934413003/diff/40001/third_party/WebKit/Source/core/events/EventUtil.h File third_party/WebKit/Source/core/events/EventUtil.h (right): https://codereview.chromium.org/1934413003/diff/40001/third_party/WebKit/Source/core/events/EventUtil.h#newcode12 third_party/WebKit/Source/core/events/EventUtil.h:12: class EventUtil { On ...
4 years, 7 months ago (2016-05-11 21:19:59 UTC) #17
sahel
https://codereview.chromium.org/1934413003/diff/60001/third_party/WebKit/Source/core/events/EventUtil.cpp File third_party/WebKit/Source/core/events/EventUtil.cpp (right): https://codereview.chromium.org/1934413003/diff/60001/third_party/WebKit/Source/core/events/EventUtil.cpp#newcode11 third_party/WebKit/Source/core/events/EventUtil.cpp:11: namespace eventUtil { On 2016/05/11 21:19:59, bokan wrote: > ...
4 years, 7 months ago (2016-05-11 21:34:43 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934413003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934413003/80001
4 years, 7 months ago (2016-05-11 21:35:48 UTC) #20
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-11 23:09:09 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934413003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934413003/80001
4 years, 7 months ago (2016-05-11 23:14:17 UTC) #25
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-11 23:20:48 UTC) #27
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 23:22:24 UTC) #29
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/db9ccdad371b96fa9b30e2fa88dcc8fc6b1bf472
Cr-Commit-Position: refs/heads/master@{#393103}

Powered by Google App Engine
This is Rietveld 408576698