- Add a new constructor to the hash table classes that allow handles to be passed in instead of cre…

- Add a new constructor to the hash table classes that allow handles to be passed in instead of creating new ones for every lookup/insertion
- Use reusable handles in Symbols::New and Symbols::Lookup with the new constructor defined above

R=hausner@google.com

Committed: https://github.com/dart-lang/sdk/commit/65c4aaee1738e5ba842ed90e4aa3a7966be2366e

[siva, 2016-05-02 23:04:43]

asiva@google.com changed reviewers:
+ hausner@google.com

[hausner, 2016-05-02 23:24:54]

LGTM

https://chromiumcodereview.appspot.com/1934263003/diff/20001/runtime/vm/hash_...
File runtime/vm/hash_table.h (right):

https://chromiumcodereview.appspot.com/1934263003/diff/20001/runtime/vm/hash_...
runtime/vm/hash_table.h:136: data_->SetAt(kOccupiedEntriesIndex, SmiHandle());
I'd find this more readable if you used *smi_handle_ directly instead of an
accessor. I'd get rid of the SmiHandle() and KeyHandle() accessors.

[siva, 2016-05-02 23:53:55]

https://chromiumcodereview.appspot.com/1934263003/diff/20001/runtime/vm/hash_...
File runtime/vm/hash_table.h (right):

https://chromiumcodereview.appspot.com/1934263003/diff/20001/runtime/vm/hash_...
runtime/vm/hash_table.h:136: data_->SetAt(kOccupiedEntriesIndex, SmiHandle());
On 2016/05/02 23:24:54, hausner wrote:
> I'd find this more readable if you used *smi_handle_ directly instead of an
> accessor. I'd get rid of the SmiHandle() and KeyHandle() accessors.

used the *smi_handle_ pattern but could not delete the accessors as it is used
in some of the derived classes.

[siva, 2016-05-03 00:07:34]

Description was changed from

==========
- Add a new constructor to the hash table classes that allow handles to be
passed in instead of creating new ones for every lookup/insertion
- Use reusable handles in Symbols::New and Symbols::Lookup with the new
constructor defined above
==========

to

==========
- Add a new constructor to the hash table classes that allow handles to be
passed in instead of creating new ones for every lookup/insertion
- Use reusable handles in Symbols::New and Symbols::Lookup with the new
constructor defined above

R=hausner@google.com

Committed:
https://github.com/dart-lang/sdk/commit/65c4aaee1738e5ba842ed90e4aa3a7966be2366e
==========

[siva, 2016-05-03 00:07:35]

Committed patchset #3 (id:40001) manually as
65c4aaee1738e5ba842ed90e4aa3a7966be2366e (presubmit successful).