Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1934233002: Cleanup partial changes to prevent scheduleRelayout() (Closed)

Created:
4 years, 7 months ago by kojii
Modified:
4 years, 7 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup partial changes to prevent scheduleRelayout() crrev.com/389691 prevents scheduleRelayout() during layout automatically in markContainerChainForLayout(), making callers of setNeedsLayout() to explicitly avoid scheduleRelayout() unnecessary. This patch cleans up previous efforts to explicitly avoid it. BUG=602908 Committed: https://crrev.com/eb09dd790c0ca396ef4a0a8c603ada6eb40ab3a0 Cr-Commit-Position: refs/heads/master@{#391123}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -12 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutObject.h View 3 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/TextAutosizer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/TextAutosizer.cpp View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kojii
PTAL. It looks like the change in markContainerChainForLayout() sticks, so I'm cleaning up previous efforts. ...
4 years, 7 months ago (2016-05-02 06:41:03 UTC) #3
cbiesinger
lgtm
4 years, 7 months ago (2016-05-02 15:34:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934233002/1
4 years, 7 months ago (2016-05-03 00:32:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 00:37:39 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 00:39:09 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb09dd790c0ca396ef4a0a8c603ada6eb40ab3a0
Cr-Commit-Position: refs/heads/master@{#391123}

Powered by Google App Engine
This is Rietveld 408576698