Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Issue 1934223004: [BlobStorage] Moving all blob files to applicable directories (Closed)

Created:
4 years, 7 months ago by dmurph
Modified:
4 years, 7 months ago
Reviewers:
michaeln, kinuko, no sievers
CC:
avayvod+watch_chromium.org, blink-worker-reviews_chromium.org, chromium-reviews, cmumford, creis+watch_chromium.org, darin-cc_chromium.org, dcheng, feature-media-reviews_chromium.org, horo+watch_chromium.org, jam, jkarlin+watch_chromium.org, jsbell+serviceworker_chromium.org, jsbell+idb_chromium.org, kinuko+serviceworker, kinuko+watch, kinuko+fileapi, loading-reviews_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-media_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nhiroki, serviceworker-reviews, tzik, wjmaclean
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[BlobStorage] Moving all blob files to applicable directories This is only file moves, this doesn't have any code or behavior changes. Committed: https://crrev.com/7ac019a90c28fec44e495be815e2fd9768ed7499 Cr-Commit-Position: refs/heads/master@{#393403}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -2911 lines) Patch
M content/browser/blob_storage/blob_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/blob_storage/blob_dispatcher_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/blob_storage/blob_reader_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/blob_storage/blob_storage_context_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/blob_storage/blob_url_request_job_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/blob_storage/chrome_blob_storage_context.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/blob_storage/chrome_blob_storage_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/cache_storage/cache_storage_blob_to_disk_cache_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/cache_storage/cache_storage_cache_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/cache_storage/cache_storage_context_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/cache_storage/cache_storage_manager_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D content/browser/fileapi/blob_reader_unittest.cc View 1 chunk +0 lines, -1218 lines 0 comments Download
D content/browser/fileapi/blob_storage_context_unittest.cc View 1 chunk +0 lines, -499 lines 0 comments Download
D content/browser/fileapi/blob_url_request_job_unittest.cc View 1 1 chunk +0 lines, -606 lines 0 comments Download
D content/browser/fileapi/chrome_blob_storage_context.h View 1 chunk +0 lines, -84 lines 0 comments Download
D content/browser/fileapi/chrome_blob_storage_context.cc View 1 chunk +0 lines, -120 lines 0 comments Download
M content/browser/fileapi/fileapi_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/fileapi_message_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/android/media_resource_getter_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/clipboard_message_filter.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/clipboard_message_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/websocket_blob_sender_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/websocket_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/resource_context_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/storage_partition_impl_map.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/url_data_manager_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/child/blob_storage/webblobregistry_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/child/blob_storage/webblobregistry_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/child/webblobregistry_impl.h View 1 chunk +0 lines, -108 lines 0 comments Download
D content/child/webblobregistry_impl.cc View 1 chunk +0 lines, -244 lines 0 comments Download
M content/content_browser.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_child.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
dmurph
Hello, I'm moving the blob files into common directories. This was mostly already done, but ...
4 years, 7 months ago (2016-05-02 22:29:17 UTC) #3
michaeln
lgtm
4 years, 7 months ago (2016-05-02 23:48:45 UTC) #4
dmurph
+kinuko, as sievers is out.
4 years, 7 months ago (2016-05-09 19:10:30 UTC) #6
kinuko
lgtm
4 years, 7 months ago (2016-05-12 09:03:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934223004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934223004/1
4 years, 7 months ago (2016-05-12 17:44:10 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/4572) ios-simulator on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-12 17:46:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934223004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934223004/20001
4 years, 7 months ago (2016-05-12 22:48:48 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-13 00:13:29 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 00:15:07 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7ac019a90c28fec44e495be815e2fd9768ed7499
Cr-Commit-Position: refs/heads/master@{#393403}

Powered by Google App Engine
This is Rietveld 408576698