Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 193413002: Only schedule a widget update when necessary (Closed)

Created:
6 years, 9 months ago by eseidel
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, abarth-chromium, jamesr, Paweł Hajdan Jr.
Visibility:
Public.

Description

Only schedule a widget update when necessary The vast majority of the Timers scheduled in Blink come from this one call in performPostLayoutTasks, at least according to my survey of the key_silk_cases. However updateWidget() already early-returns if there are no widgets to update. This moves the timer scheduling into its own function (so that the FROM_HERE result is more descriptive) and also checks the same early-return as updateWidget, just before bothering to schedule the timer. I do not expect this to have a performance impact, since scheduling a timer should be cheap and in the common case (no plugins) these timers would always just immediately exit on firing but at least removing this timer schedule will reduce chatter in our trace files if nothing else. NOTRY=true BUG=350592 R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168883

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M Source/core/frame/FrameView.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 3 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
eseidel
6 years, 9 months ago (2014-03-10 23:00:23 UTC) #1
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-10 23:32:04 UTC) #2
abarth-chromium
I bet this saves a bunch of power.
6 years, 9 months ago (2014-03-10 23:32:20 UTC) #3
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 9 months ago (2014-03-10 23:32:20 UTC) #4
eseidel
It's juicy!
6 years, 9 months ago (2014-03-10 23:39:58 UTC) #5
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 9 months ago (2014-03-10 23:45:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/193413002/1
6 years, 9 months ago (2014-03-10 23:45:36 UTC) #7
tonyg
Nice! Reducing wakeups should be very juicy indeed. We can keep an eye on one ...
6 years, 9 months ago (2014-03-11 00:02:38 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 01:02:50 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink
6 years, 9 months ago (2014-03-11 01:02:50 UTC) #10
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 9 months ago (2014-03-11 02:37:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/193413002/1
6 years, 9 months ago (2014-03-11 02:37:28 UTC) #12
eseidel
Sorry CQ, I give up on you.
6 years, 9 months ago (2014-03-11 04:44:37 UTC) #13
eseidel
The CQ bit was unchecked by eseidel@chromium.org
6 years, 9 months ago (2014-03-11 04:44:49 UTC) #14
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 9 months ago (2014-03-11 04:44:50 UTC) #15
eseidel
6 years, 9 months ago (2014-03-11 05:07:54 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 manually as r168883 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698