Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2829)

Unified Diff: ash/pointer_watcher_delegate_aura.cc

Issue 1934123004: mash: Fix shelf overflow bubble not closing on click outside its bounds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2openoverflow
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/pointer_watcher_delegate_aura.h ('k') | ash/shelf/overflow_bubble.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/pointer_watcher_delegate_aura.cc
diff --git a/ash/pointer_watcher_delegate_aura.cc b/ash/pointer_watcher_delegate_aura.cc
index f2050bdd90143227f5baa1bd106d90759db2f8a1..413ea71bb58bd019f77ac92646754bfb1207b0a6 100644
--- a/ash/pointer_watcher_delegate_aura.cc
+++ b/ash/pointer_watcher_delegate_aura.cc
@@ -5,8 +5,11 @@
#include "ash/pointer_watcher_delegate_aura.h"
#include "ash/shell.h"
+#include "ui/aura/client/screen_position_client.h"
+#include "ui/aura/window.h"
#include "ui/events/event.h"
#include "ui/events/event_constants.h"
+#include "ui/gfx/geometry/point.h"
#include "ui/views/pointer_watcher.h"
namespace ash {
@@ -32,13 +35,22 @@ void PointerWatcherDelegateAura::RemovePointerWatcher(
void PointerWatcherDelegateAura::OnMouseEvent(ui::MouseEvent* event) {
if (event->type() == ui::ET_MOUSE_PRESSED)
FOR_EACH_OBSERVER(views::PointerWatcher, pointer_watchers_,
- OnMousePressed(*event));
+ OnMousePressed(*event, GetLocationInScreen(*event)));
}
void PointerWatcherDelegateAura::OnTouchEvent(ui::TouchEvent* event) {
if (event->type() == ui::ET_TOUCH_PRESSED)
FOR_EACH_OBSERVER(views::PointerWatcher, pointer_watchers_,
- OnTouchPressed(*event));
+ OnTouchPressed(*event, GetLocationInScreen(*event)));
+}
+
+gfx::Point PointerWatcherDelegateAura::GetLocationInScreen(
+ const ui::LocatedEvent& event) const {
+ aura::Window* target = static_cast<aura::Window*>(event.target());
+ gfx::Point location_in_screen = event.location();
+ aura::client::GetScreenPositionClient(target->GetRootWindow())
+ ->ConvertPointToScreen(target, &location_in_screen);
+ return location_in_screen;
}
} // namespace ash
« no previous file with comments | « ash/pointer_watcher_delegate_aura.h ('k') | ash/shelf/overflow_bubble.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698