mash: Fix shelf overflow bubble not closing on click outside its bounds

ash/shelf/overflow_bubble.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/shelf/overflow_bubble.h"
 
 #include "ash/shelf/overflow_bubble_view.h"
 #include "ash/shelf/shelf.h"
 #include "ash/shelf/shelf_view.h"
 #include "ash/shelf/shelf_widget.h"
 #include "ash/shell.h"
 #include "ash/system/tray/tray_background_view.h"
 #include "ui/aura/client/screen_position_client.h"
-#include "ui/aura/window_event_dispatcher.h"
 #include "ui/events/event.h"
 #include "ui/views/widget/widget.h"
 
 namespace ash {
 
 OverflowBubble::OverflowBubble()
     : bubble_(NULL),
       anchor_(NULL),
       shelf_view_(NULL) {
 }
 
 OverflowBubble::~OverflowBubble() {
   Hide();
 }
 
 void OverflowBubble::Show(views::View* anchor, ShelfView* shelf_view) {
   Hide();
 
   bubble_ = new OverflowBubbleView();
   bubble_->InitOverflowBubble(anchor, shelf_view);
   shelf_view_ = shelf_view;
   anchor_ = anchor;
 
-  // TODO(jamescook): Change this to a PointerWatcher.
-  Shell::GetInstance()->AddPreTargetHandler(this);
+  Shell::GetInstance()->AddPointerWatcher(this);
 
   TrayBackgroundView::InitializeBubbleAnimations(bubble_->GetWidget());
   bubble_->GetWidget()->AddObserver(this);
   bubble_->GetWidget()->Show();
 }
 
 void OverflowBubble::Hide() {
   if (!IsShowing())
     return;
 
-  Shell::GetInstance()->RemovePreTargetHandler(this);
+  Shell::GetInstance()->RemovePointerWatcher(this);
   bubble_->GetWidget()->RemoveObserver(this);
   bubble_->GetWidget()->Close();
   bubble_ = NULL;
   anchor_ = NULL;
   shelf_view_ = NULL;
 }
 
 void OverflowBubble::HideBubbleAndRefreshButton() {
   if (!IsShowing())
     return;
 
   views::View* anchor = anchor_;
   Hide();
   // Update overflow button (|anchor|) status when overflow bubble is hidden
   // by outside event of overflow button.
   anchor->SchedulePaint();
 }
 
-void OverflowBubble::ProcessPressedEvent(ui::LocatedEvent* event) {
-  aura::Window* target = static_cast<aura::Window*>(event->target());
-  gfx::Point event_location_in_screen = event->location();
-  aura::client::GetScreenPositionClient(target->GetRootWindow())->
-      ConvertPointToScreen(target, &event_location_in_screen);
+void OverflowBubble::ProcessPressedEvent(const ui::LocatedEvent& event) {
+  aura::Window* root = bubble_->GetWidget()->GetNativeWindow()->GetRootWindow();
+  gfx::Point event_location_in_screen = event.root_location();
+  aura::client::GetScreenPositionClient(root)->ConvertPointToScreen(

[msw, 2016/05/02 17:18:13]

Will this work? What is the coordinate system used for event.root_location()? If
it's in the space of some other root window, then using the bubble's root won't
work for getting the actual screen coordinate, right?

[James Cook, 2016/05/02 17:48:34]

Yes, I think this is wrong for multi-display. Good catch.

I need to look at this some more. I'll ping again when I have a solution.

I would hold off on your patch to close tooltips on touch until I sort out the
coordinate systems with PointerWatcher.

+      root, &event_location_in_screen);
   if (!shelf_view_->IsShowingMenu() &&
       !bubble_->GetBoundsInScreen().Contains(event_location_in_screen) &&
       !anchor_->GetBoundsInScreen().Contains(event_location_in_screen)) {
     HideBubbleAndRefreshButton();
   }
 }
 
-void OverflowBubble::OnMouseEvent(ui::MouseEvent* event) {
-  if (event->type() == ui::ET_MOUSE_PRESSED)
-    ProcessPressedEvent(event);
+void OverflowBubble::OnMousePressed(const ui::MouseEvent& event) {
+  ProcessPressedEvent(event);
 }
 
-void OverflowBubble::OnTouchEvent(ui::TouchEvent* event) {
-  if (event->type() == ui::ET_TOUCH_PRESSED)
-    ProcessPressedEvent(event);
+void OverflowBubble::OnTouchPressed(const ui::TouchEvent& event) {
+  ProcessPressedEvent(event);
 }
 
 void OverflowBubble::OnWidgetDestroying(views::Widget* widget) {
   DCHECK(widget == bubble_->GetWidget());
   bubble_ = NULL;
   anchor_ = NULL;
   shelf_view_->shelf()->SchedulePaint();
   shelf_view_ = NULL;
 }
 
 }  // namespace ash