BUILD.gn - Issue 1934083002: [Cronet] Use gn desc deps to find third_party licenses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: BUILD.gn

Issue 1934083002: [Cronet] Use gn desc deps to find third_party licenses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Andrei's comments. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn

index 7903e89d45f5301890429048a1ca8c1a89befab6..b68c9e5811800e3c747fe4e4cf6040e71ba846f1 100644

--- a/BUILD.gn

+++ b/BUILD.gn

@@ -247,6 +247,10 @@ group("both_gn_and_gyp") {

"//ios/web:ios_web_unittests",

"//ios/web/shell:ios_web_shell",

]

+ if (!is_component_build) {

+ deps += [ "//components/cronet/ios:cronet_package" ]

+ }

}

deps += root_extra_deps

« no previous file with comments | « no previous file | components/cronet/ios/BUILD.gn » ('j') | components/cronet/tools/cronet_licenses.py » ('J')