Move relevent JS tests to mojo_js_unittests

Move relevent JS tests to mojo_js_unittests

BUG=none
TEST=none
R=viettrungluu@chromium.org, vtl@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256241

[viettrungluu, 2014-03-11 05:08:03]

LGTM, but could you also update the list of tests in mojo/tools/mojob.sh?

[sky, 2014-03-11 14:58:23]

I didn't realize we had a mojob.sh. Nice! Updated.

[sky, 2014-03-11 15:48:44]

Committed patchset #5 manually as r256241 (presubmit successful).

[yzshen1, 2014-03-11 17:43:43]

On 2014/03/11 15:48:44, sky wrote:
> Committed patchset #5 manually as r256241 (presubmit successful).

Drive-by comments:
Last night I just added mojo unittests to chromium_trybot and waterfall bots,
including mojo_js_unittests:
http://chromegw.corp.google.com/viewvc/chrome?view=rev&revision=256147

Now that you move some tests to mojo_apps_js_unittests, shall we also run it on
bots?

[sky, 2014-03-11 17:48:57]

Yes, these should be run on the bots as well.

  -Scott

On Tue, Mar 11, 2014 at 10:43 AM,  <yzshen@chromium.org> wrote:
> On 2014/03/11 15:48:44, sky wrote:
>>
>> Committed patchset #5 manually as r256241 (presubmit successful).
>
>
> Drive-by comments:
> Last night I just added mojo unittests to chromium_trybot and waterfall
> bots,
> including mojo_js_unittests:
> http://chromegw.corp.google.com/viewvc/chrome?view=rev&revision=256147
>
> Now that you move some tests to mojo_apps_js_unittests, shall we also run it
> on
> bots?
>
> https://codereview.chromium.org/193403003/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[yzshen, 2014-03-11 17:50:54]

Thanks, Scott.

I could write a CL for that if you haven't already done so.


On Tue, Mar 11, 2014 at 10:48 AM, Scott Violet <sky@chromium.org> wrote:

> Yes, these should be run on the bots as well.
>
>   -Scott
>
> On Tue, Mar 11, 2014 at 10:43 AM,  <yzshen@chromium.org> wrote:
> > On 2014/03/11 15:48:44, sky wrote:
> >>
> >> Committed patchset #5 manually as r256241 (presubmit successful).
> >
> >
> > Drive-by comments:
> > Last night I just added mojo unittests to chromium_trybot and waterfall
> > bots,
> > including mojo_js_unittests:
> > http://chromegw.corp.google.com/viewvc/chrome?view=rev&revision=256147
> >
> > Now that you move some tests to mojo_apps_js_unittests, shall we also
> run it
> > on
> > bots?
> >
> > https://codereview.chromium.org/193403003/
>



-- 
Best regards,
Yuzhu Shen.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sky, 2014-03-11 18:04:33]

If you have the time to write a patch that would be awesome.

  -Scott

On Tue, Mar 11, 2014 at 10:50 AM, Yuzhu Shen <yzshen@google.com> wrote:
> Thanks, Scott.
>
> I could write a CL for that if you haven't already done so.
>
>
> On Tue, Mar 11, 2014 at 10:48 AM, Scott Violet <sky@chromium.org> wrote:
>>
>> Yes, these should be run on the bots as well.
>>
>>   -Scott
>>
>> On Tue, Mar 11, 2014 at 10:43 AM,  <yzshen@chromium.org> wrote:
>> > On 2014/03/11 15:48:44, sky wrote:
>> >>
>> >> Committed patchset #5 manually as r256241 (presubmit successful).
>> >
>> >
>> > Drive-by comments:
>> > Last night I just added mojo unittests to chromium_trybot and waterfall
>> > bots,
>> > including mojo_js_unittests:
>> > http://chromegw.corp.google.com/viewvc/chrome?view=rev&revision=256147
>> >
>> > Now that you move some tests to mojo_apps_js_unittests, shall we also
>> > run it
>> > on
>> > bots?
>> >
>> > https://codereview.chromium.org/193403003/
>
>
>
>
> --
> Best regards,
> Yuzhu Shen.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.