printing/backend/print_backend.cc - Issue 1934013002: Enable the cups backend when --enable-native-cups is specified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: printing/backend/print_backend.cc

Issue 1934013002: Enable the cups backend when --enable-native-cups is specified. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cupsFlag

Patch Set: Move flag check Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: printing/backend/print_backend.cc

diff --git a/printing/backend/print_backend.cc b/printing/backend/print_backend.cc

index f17983778d76a8998f02e801dc98d6e993210e3a..35a9a1c0b211e0e86f159087f616c1e7dd7a2c12 100644

--- a/printing/backend/print_backend.cc

+++ b/printing/backend/print_backend.cc

@@ -4,6 +4,10 @@

#include "printing/backend/print_backend.h"

+namespace {

+static bool native_cups_enabled = false;

Lei Zhang 2016/06/29 00:22:31 You don't need static in an anonymous namespace.

Lei Zhang 2016/06/29 00:22:31 g_native_cups_enabled

skau 2016/06/29 00:40:16 Done.

skau 2016/06/29 00:40:17 Done.

+} // namespace

namespace printing {

PrinterBasicInfo::PrinterBasicInfo()

@@ -40,4 +44,12 @@ PrinterCapsAndDefaults::~PrinterCapsAndDefaults() {}

PrintBackend::~PrintBackend() {}

+bool PrintBackend::GetNativeCupsEnabled() {

Lei Zhang 2016/06/29 00:22:31 Add: // static above this line, same for SetNative

skau 2016/06/29 00:40:17 Done.

+ return native_cups_enabled;

+void PrintBackend::SetNativeCupsEnabled(bool enabled) {

+ native_cups_enabled = enabled;

} // namespace printing

« no previous file with comments | « printing/backend/print_backend.h ('k') | printing/backend/print_backend_chromeos.cc » ('j') | printing/backend/print_backend_chromeos.cc » ('J')