Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 1933943002: fiddle: fix build (Closed)

Created:
4 years, 7 months ago by jcgregorio
Modified:
4 years, 7 months ago
Reviewers:
rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fiddle: fix build Remove the lock from updateCurrent to avoid deadlocking on the mutex. Also simplify the code by keeping the list of hashes in the same order as they are found in the goodbuilds.txt file. BUG=skia: TBR=rmistry Committed: https://skia.googlesource.com/buildbot/+/628dbb95c47455646bae270e6c1075428adb05fb

Patch Set 1 #

Patch Set 2 : remove all the reversing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -54 lines) Patch
M fiddle/go/builder/builder.go View 1 8 chunks +33 lines, -36 lines 0 comments Download
M fiddle/go/builder/builder_test.go View 1 2 chunks +18 lines, -18 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
jcgregorio
4 years, 7 months ago (2016-04-29 20:24:06 UTC) #3
rmistry
lgtm
4 years, 7 months ago (2016-04-29 20:32:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933943002/20001
4 years, 7 months ago (2016-04-29 21:12:55 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-04-29 21:15:39 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/buildbot/+/628dbb95c47455646bae270e6c1075428adb...

Powered by Google App Engine
This is Rietveld 408576698