Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Unified Diff: runtime/vm/scanner.cc

Issue 1933933002: Use a reusable handle in SubString instead of creating one as this path is now used when creating S… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: pass-thread Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/scanner.cc
diff --git a/runtime/vm/scanner.cc b/runtime/vm/scanner.cc
index 19509b5188b1917121ae9595b91f920ab4c46813..4b1e550db421ed796b2955c1606626de8c81174f 100644
--- a/runtime/vm/scanner.cc
+++ b/runtime/vm/scanner.cc
@@ -332,7 +332,7 @@ void Scanner::ScanIdentChars(bool allow_dollar) {
String& literal = String::ZoneHandle(Z);
if (ident_char0 == Library::kPrivateIdentifierStart) {
// Private identifiers are mangled on a per library basis.
- literal = String::SubString(source_, ident_pos, ident_length);
+ literal = String::SubString(T, source_, ident_pos, ident_length);
literal = Symbols::FromConcat(T, literal, private_key_);
} else {
literal = Symbols::New(T, source_, ident_pos, ident_length);
« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698