Issue 1933933002: Use a reusable handle in SubString instead of creating one as this path is now used when creating S…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1933933002: Use a reusable handle in SubString instead of creating one as this path is now used when creating S… (Closed)

Created:
4 years, 7 months ago by siva

Modified:
4 years, 7 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Use a reusable handle in SubString instead of creating one as this path is now used when creating Symbols of identifiers. R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/d5583d6a791e919eee74b34a9602bcc99e52656a

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -3 lines)			Patch
M	runtime/vm/object.h	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	3 chunks	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/scanner.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

siva

4 years, 7 months ago (2016-04-29 21:53:11 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
d5583d6a791e919eee74b34a9602bcc99e52656a (presubmit successful).