Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 193393002: [webcrypto] Change HMAC key generation length from bytes to bits. (Closed)

Created:
6 years, 9 months ago by eroman
Modified:
6 years, 9 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

[webcrypto] Change HMAC key generation length from bytes to bits. This is the final CL that removes the ifdef once blink has rolled. BUG=245025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256729

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M content/child/webcrypto/shared_crypto.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/child/webcrypto/shared_crypto_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
eroman
6 years, 9 months ago (2014-03-10 22:43:30 UTC) #1
Ryan Sleevi
lgtm
6 years, 9 months ago (2014-03-10 23:48:47 UTC) #2
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 9 months ago (2014-03-12 02:19:19 UTC) #3
eroman
The CQ bit was unchecked by eroman@chromium.org
6 years, 9 months ago (2014-03-12 02:19:33 UTC) #4
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 9 months ago (2014-03-12 02:20:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/193393002/1
6 years, 9 months ago (2014-03-12 02:24:51 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-12 10:06:45 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=280405
6 years, 9 months ago (2014-03-12 10:06:45 UTC) #8
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 9 months ago (2014-03-12 23:06:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/193393002/1
6 years, 9 months ago (2014-03-12 23:08:08 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-13 01:46:09 UTC) #11
Message was sent while issue was closed.
Change committed as 256729

Powered by Google App Engine
This is Rietveld 408576698