chrome/browser/resources/settings/people_page/pin.js - Issue 1933913002: Add a very basic PIN UI implementation that is shared between lock and settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/people_page/pin.js

Issue 1933913002: Add a very basic PIN UI implementation that is shared between lock and settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/quick_unlock/pin.html ('K') | « chrome/browser/resources/settings/people_page/pin.html ('k') | chrome/browser/resources/settings/settings_resources.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/people_page/pin.js

diff --git a/chrome/test/data/extensions/api_test/executescript/http204/at_document_end_unexpected.js b/chrome/browser/resources/settings/people_page/pin.js

similarity index 76%

copy from chrome/test/data/extensions/api_test/executescript/http204/at_document_end_unexpected.js

copy to chrome/browser/resources/settings/people_page/pin.js

index 456b59ee4528452a1b0a64916f9c64c360a0bd44..244c1bb97ccf5c3c734bcd869321a03d9aedb740 100644

--- a/chrome/test/data/extensions/api_test/executescript/http204/at_document_end_unexpected.js

+++ b/chrome/browser/resources/settings/people_page/pin.js

@@ -2,4 +2,4 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-window.didRunAtDocumentEndUnexpected = true;

+<include src="../../chromeos/quick_unlock/pin.js">

tommycli 2016/05/06 18:15:44 This code sharing is just fine with me (assuming i

jdufault 2016/05/06 23:44:18 Done.