chrome/browser/resources/settings/people_page/people_page.html - Issue 1933913002: Add a very basic PIN UI implementation that is shared between lock and settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/people_page/people_page.html

Issue 1933913002: Add a very basic PIN UI implementation that is shared between lock and settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Fix tests by removing a previously unused import that started getting used b/c of resource loader c… Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js ('k') | chrome/browser/resources/settings/people_page/people_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/people_page/people_page.html

diff --git a/chrome/browser/resources/settings/people_page/people_page.html b/chrome/browser/resources/settings/people_page/people_page.html

index 234a5c657b6e0fd8d3b11fdb4ffaadbabd062b03..9be8bfd606a0494e8ab390a6336429828666ccb3 100644

--- a/chrome/browser/resources/settings/people_page/people_page.html

+++ b/chrome/browser/resources/settings/people_page/people_page.html

@@ -15,6 +15,7 @@

+<link rel="import" href="chrome://md-settings/people_page/pin_keyboard.html">

@@ -126,6 +127,16 @@

</div>

+ <!-- TODO(jdufault): Confirm if this goes above or below easy unlock

+ settings. -->

+ <template is="dom-if" if=[[pinUnlockAllowed_]]>

+ <div class="settings-box">

+

+ <p>Quick Unlock PIN</p>

+ <pin-keyboard></pin-keyboard>

+ </div>

+ </template>

<settings-checkbox pref="{{prefs.settings.enable_screen_lock}}"

i18n-values="label:enableScreenlock">