Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Side by Side Diff: chrome/browser/resources/settings/people_page/people_page.js

Issue 1933913002: Add a very basic PIN UI implementation that is shared between lock and settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Use ResourceLoader, rename pin.* to pin_keyboard.* Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-people-page' is the settings page containing sign-in settings. 7 * 'settings-people-page' is the settings page containing sign-in settings.
8 * 8 *
9 * Example: 9 * Example:
10 * 10 *
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 56
57 /** @private {!settings.SyncBrowserProxyImpl} */ 57 /** @private {!settings.SyncBrowserProxyImpl} */
58 syncBrowserProxy_: { 58 syncBrowserProxy_: {
59 type: Object, 59 type: Object,
60 value: function() { 60 value: function() {
61 return settings.SyncBrowserProxyImpl.getInstance(); 61 return settings.SyncBrowserProxyImpl.getInstance();
62 }, 62 },
63 }, 63 },
64 64
65 <if expr="chromeos"> 65 <if expr="chromeos">
66 /**
67 * True if Pin Unlock is allowed on this machine.
68 */
69 pinUnlockAllowed_: {
70 type: Boolean,
71 value: function() {
72 /* TODO(jdufault): Return a real value via quickUnlockPrivate API. */
73 return false;
74 },
75 readOnly: true,
76 },
77
66 /** @private {!settings.EasyUnlockBrowserProxyImpl} */ 78 /** @private {!settings.EasyUnlockBrowserProxyImpl} */
67 easyUnlockBrowserProxy_: { 79 easyUnlockBrowserProxy_: {
68 type: Object, 80 type: Object,
69 value: function() { 81 value: function() {
70 return settings.EasyUnlockBrowserProxyImpl.getInstance(); 82 return settings.EasyUnlockBrowserProxyImpl.getInstance();
71 }, 83 },
72 }, 84 },
73 85
74 /** 86 /**
75 * True if Easy Unlock is allowed on this machine. 87 * True if Easy Unlock is allowed on this machine.
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 190
179 <if expr="not chromeos"> 191 <if expr="not chromeos">
180 /** @private */ 192 /** @private */
181 onProfileNameTap_: function() { 193 onProfileNameTap_: function() {
182 this.$.pages.setSubpageChain(['manageProfile']); 194 this.$.pages.setSubpageChain(['manageProfile']);
183 }, 195 },
184 </if> 196 </if>
185 197
186 /** @private */ 198 /** @private */
187 onActivityControlsTap_: function() { 199 onActivityControlsTap_: function() {
188 this.syncBrowserProxy_.openActivityControlsUrl(); 200 this.syncBrowserProxy_.openActivityControlsUrl();
tommycli 2016/05/06 23:54:18 This will break the closure compiler since this me
jdufault 2016/05/10 18:45:23 Rebase change.
189 }, 201 },
190 202
191 /** @private */ 203 /** @private */
192 onSigninTap_: function() { 204 onSigninTap_: function() {
193 this.syncBrowserProxy_.startSignIn(); 205 this.syncBrowserProxy_.startSignIn();
194 }, 206 },
195 207
196 /** @private */ 208 /** @private */
197 onDisconnectTap_: function() { 209 onDisconnectTap_: function() {
198 this.$.disconnectDialog.open(); 210 this.$.disconnectDialog.open();
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 255
244 /** 256 /**
245 * @private 257 * @private
246 * @return {boolean} 258 * @return {boolean}
247 */ 259 */
248 isAdvancedSyncSettingsVisible_: function(syncStatus) { 260 isAdvancedSyncSettingsVisible_: function(syncStatus) {
249 return syncStatus && syncStatus.signedIn && !syncStatus.managed && 261 return syncStatus && syncStatus.signedIn && !syncStatus.managed &&
250 syncStatus.syncSystemEnabled; 262 syncStatus.syncSystemEnabled;
251 }, 263 },
252 }); 264 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698