chrome/browser/resources/chromeos/quick_unlock/pin.html - Issue 1933913002: Add a very basic PIN UI implementation that is shared between lock and settings.

Side by Side Diff: chrome/browser/resources/chromeos/quick_unlock/pin.html

Issue 1933913002: Add a very basic PIN UI implementation that is shared between lock and settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/chromeos/quick_unlock/pin.css ('K') | « chrome/browser/resources/chromeos/quick_unlock/pin.css ('k') | chrome/browser/resources/chromeos/quick_unlock/pin.js » ('j') | chrome/browser/resources/chromeos/quick_unlock/pin.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import"href="chrome://resources/polymer/v1_0/polymer/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">

	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">

	4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.h tml">

	5

	6 <dom-module id="pin-keyboard">

	7 <link rel="import" type="css" href="pin.css">

	8

	9 <template>

	10 <div id="root">

	11 <div id="container-constrained-width">

	12 <div id="profile-picture">

	13 </div>

	14

	15 <div class="row horizontal-center">

	16 <input id="pin-input" type="number" placeholder="Enter PIN"></input>
	tommycli 2016/05/02 16:11:27 Typically we use i18n strings instead of string li Typically we use i18n strings instead of string literals. jdufault 2016/05/03 19:21:57 Added TODO. Show quoted text On 2016/05/02 16:11:27, tommycli wrote: > Typically we use i18n strings instead of string literals. Added TODO.
	17 </div>

	18

	19 <div class="row keyboard">

	20 <paper-button class="btn custom-appearance" id="btn1">
	tommycli 2016/05/02 16:11:27 custom-appearance is no longer needed right? custom-appearance is no longer needed right? jdufault 2016/05/03 19:21:57 Done. When I wrote the element I initially used < Show quoted text On 2016/05/02 16:11:27, tommycli wrote: > custom-appearance is no longer needed right? Done. When I wrote the element I initially used <button> - some global styles applied to it (even through the shady/shadow DOM), but those global styles do not apply to paper-button.
	21 <inner-text>1</inner-text>

	22 </paper-button>

	23 <paper-button class="btn custom-appearance" id="btn2">

	24 <inner-text>2<subhead>ABC</subhead></inner-text>
	tommycli 2016/05/02 16:11:27 What is the internationalization of the numeric pi What is the internationalization of the numeric pinpad? Is it truly 1 -> ABC, 2 -> DEF, internationally? jdufault 2016/05/03 19:21:57 Added TODO Show quoted text On 2016/05/02 16:11:27, tommycli wrote: > What is the internationalization of the numeric pinpad? Is it truly 1 -> ABC, 2 > -> DEF, internationally? Added TODO
	25 </paper-button>

	26 <paper-button class="btn custom-appearance" id="btn3">

	27 <inner-text>3<subhead>DEF</subhead></inner-text>

	28 </paper-button>

	29 </div>

	30 <div class="row keyboard">

	31 <paper-button class="btn custom-appearance" id="btn4">

	32 <inner-text>4<subhead>GHI</subhead></inner-text>

	33 </paper-button>

	34 <paper-button class="btn custom-appearance" id="btn5">

	35 <inner-text>5<subhead>JKL</subhead></inner-text>

	36 </paper-button>

	37 <paper-button class="btn custom-appearance" id="btn6">

	38 <inner-text>6<subhead>MNO</subhead></inner-text>

	39 </paper-button>

	40 </div>

	41 <div class="row keyboard">

	42 <paper-button class="btn custom-appearance" id="btn7">

	43 <inner-text>7<subhead>PQRS</subhead></inner-text>

	44 </paper-button>

	45 <paper-button class="btn custom-appearance" id="btn8">

	46 <inner-text>8<subhead>TUV</subhead></inner-text>

	47 </paper-button>

	48 <paper-button class="btn custom-appearance" id="btn9">

	49 <inner-text>9<subhead>WXYZ</subhead></inner-text>

	50 </paper-button>

	51 </div>

	52 <div class="row keyboard">

	53 <div class="blank-element"></div>

	54 <paper-button class="btn custom-appearance" id="btn0">

	55 <inner-text>0</inner-text>

	56 </paper-button>

	57 <div id="submitContainer">
	xiyuan 2016/05/02 20:03:33 nit: We don't use camel case for element id. submi nit: We don't use camel case for element id. submitContainer -> submit-container jdufault 2016/05/03 19:21:57 Done. Show quoted text On 2016/05/02 20:03:33, xiyuan wrote: > nit: We don't use camel case for element id. submitContainer -> submit-container Done.
	58 <paper-icon-button class="btn custom-appearance" icon="icons:check"

	59 id="submitButton"></paper-icon-button>
	xiyuan 2016/05/02 20:03:33 nit: submitButton -> submit-button nit: submitButton -> submit-button jdufault 2016/05/03 19:21:57 Done. Show quoted text On 2016/05/02 20:03:33, xiyuan wrote: > nit: submitButton -> submit-button Done.
	60 </div>

	61 </div>

	62 </div>

	63 </div>

	64 </template>

	65 <script src="pin.js"></script>

	66 </dom-module>

OLD	NEW