Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 1933863002: Revert of Introduce SkGammas type to represent ICC gamma curves (Closed)

Created:
4 years, 7 months ago by msarett
Modified:
4 years, 7 months ago
Reviewers:
scroggo, Brian Osman, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@delcolorspace
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Introduce SkGammas type to represent ICC gamma curves (patchset #7 id:40002 of https://codereview.chromium.org/1928123002/ ) Reason for revert: Breaks TSAN https://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN/builds/6387/steps/dm/logs/stdio Original issue's description: > Introduce SkGammas type to represent ICC gamma curves > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1928123002 > > Committed: https://skia.googlesource.com/skia/+/7b2c6dd8c918209cb92e1338905d511c68da3eb2 TBR=scroggo@google.com,reed@google.com,brianosman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/a2ffa98323a17036c6df018127e3723099458a93

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -172 lines) Patch
M src/codec/SkPngCodec.cpp View 3 chunks +13 lines, -15 lines 0 comments Download
M src/core/SkColorSpace.h View 1 chunk +27 lines, -91 lines 0 comments Download
M src/core/SkColorSpace.cpp View 10 chunks +60 lines, -52 lines 0 comments Download
M tests/ColorSpaceTest.cpp View 2 chunks +10 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
msarett
Created Revert of Introduce SkGammas type to represent ICC gamma curves
4 years, 7 months ago (2016-04-29 18:12:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933863002/1
4 years, 7 months ago (2016-04-29 18:12:18 UTC) #2
commit-bot: I haz the power
4 years, 7 months ago (2016-04-29 18:12:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a2ffa98323a17036c6df018127e3723099458a93

Powered by Google App Engine
This is Rietveld 408576698