Use utilities from build directory instead of own copies

Use utilities from build directory instead of own copies

GYP and GN builds share some common utilities. GYP has three utilities
in its own directory which are also synced in build directory now.
We will use utilities from build directory instead of keeping our own
copies.

Compared to our own copies, utilities in build directory
are either same or newer. 
find_depot_tools.py is identical;
vs_toolchain.py and find_sdk.py have some minor updates.

Committed: https://pdfium.googlesource.com/pdfium/+/5593bb8573c1deb1c649083d51963348adf972da

[Wei Li, 2016-04-29 18:28:48]

Description was changed from

==========
Use utilities from build directory instead of own copy

GYP and GN builds share some common utilities. GYP has three utilities
in its own directory which are also synced in build directory now.
We will use utilities from build directory instead of keeping our own
copies.
==========

to

==========
Use utilities from build directory instead of own copy

GYP and GN builds share some common utilities. GYP has three utilities
in its own directory which are also synced in build directory now.
We will use utilities from build directory instead of keeping our own
copies.

Compared to our own copies, utilities in build directory
are either same or newer. 
find_depot_tool.py is identical;
vs_toolchain.py and find_sdk.py has some minor updates.
==========

[Wei Li, 2016-04-29 18:29:43]

Description was changed from

==========
Use utilities from build directory instead of own copy

GYP and GN builds share some common utilities. GYP has three utilities
in its own directory which are also synced in build directory now.
We will use utilities from build directory instead of keeping our own
copies.

Compared to our own copies, utilities in build directory
are either same or newer. 
find_depot_tool.py is identical;
vs_toolchain.py and find_sdk.py has some minor updates.
==========

to

==========
Use utilities from build directory instead of own copy

GYP and GN builds share some common utilities. GYP has three utilities
in its own directory which are also synced in build directory now.
We will use utilities from build directory instead of keeping our own
copies.

Compared to our own copies, utilities in build directory
are either same or newer. 
find_depot_tools.py is identical;
vs_toolchain.py and find_sdk.py has some minor updates.
==========

[Wei Li, 2016-04-29 18:29:43]

weili@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[Wei Li, 2016-04-29 18:30:38]

Description was changed from

==========
Use utilities from build directory instead of own copy

GYP and GN builds share some common utilities. GYP has three utilities
in its own directory which are also synced in build directory now.
We will use utilities from build directory instead of keeping our own
copies.

Compared to our own copies, utilities in build directory
are either same or newer. 
find_depot_tools.py is identical;
vs_toolchain.py and find_sdk.py has some minor updates.
==========

to

==========
Use utilities from build directory instead of own copy

GYP and GN builds share some common utilities. GYP has three utilities
in its own directory which are also synced in build directory now.
We will use utilities from build directory instead of keeping our own
copies.

Compared to our own copies, utilities in build directory
are either same or newer. 
find_depot_tools.py is identical;
vs_toolchain.py and find_sdk.py have some minor updates.
==========

[Wei Li, 2016-04-29 18:31:19]

Description was changed from

==========
Use utilities from build directory instead of own copy

GYP and GN builds share some common utilities. GYP has three utilities
in its own directory which are also synced in build directory now.
We will use utilities from build directory instead of keeping our own
copies.

Compared to our own copies, utilities in build directory
are either same or newer. 
find_depot_tools.py is identical;
vs_toolchain.py and find_sdk.py have some minor updates.
==========

to

==========
Use utilities from build directory instead of own copies

GYP and GN builds share some common utilities. GYP has three utilities
in its own directory which are also synced in build directory now.
We will use utilities from build directory instead of keeping our own
copies.

Compared to our own copies, utilities in build directory
are either same or newer. 
find_depot_tools.py is identical;
vs_toolchain.py and find_sdk.py have some minor updates.
==========

[Wei Li, 2016-04-29 18:32:01]

for review, thanks

[Lei Zhang, 2016-04-29 18:34:52]

https://codereview.chromium.org/1933843002/diff/1/DEPS
File DEPS (left):

https://codereview.chromium.org/1933843002/diff/1/DEPS#oldcode172
DEPS:172: {
If we remove this block, then where does the VS toolchain update happen?

[Wei Li, 2016-04-29 18:47:36]

https://codereview.chromium.org/1933843002/diff/1/DEPS
File DEPS (left):

https://codereview.chromium.org/1933843002/diff/1/DEPS#oldcode172
DEPS:172: {
On 2016/04/29 18:34:52, Lei Zhang wrote:
> If we remove this block, then where does the VS toolchain update happen?

Should be synced along with the whole build dir based on revision in this file

[Lei Zhang, 2016-04-29 21:22:02]

https://codereview.chromium.org/1933843002/diff/1/DEPS
File DEPS (left):

https://codereview.chromium.org/1933843002/diff/1/DEPS#oldcode172
DEPS:172: {
On 2016/04/29 18:47:36, Wei Li wrote:
> On 2016/04/29 18:34:52, Lei Zhang wrote:
> > If we remove this block, then where does the VS toolchain update happen?
> 
> Should be synced along with the whole build dir based on revision in this file

So I see build/vs_toolchain.py exists and it gets updated when build/ gets
updates. What about the actual VS toolchain that vs_tollchain.py is suppose to
update? Wasn't running this hook what gets us the VS toolchain? Or am I missing
something?

[Wei Li, 2016-04-30 00:03:38]

https://codereview.chromium.org/1933843002/diff/1/DEPS
File DEPS (left):

https://codereview.chromium.org/1933843002/diff/1/DEPS#oldcode172
DEPS:172: {
On 2016/04/29 21:22:02, Lei Zhang wrote:
> On 2016/04/29 18:47:36, Wei Li wrote:
> > On 2016/04/29 18:34:52, Lei Zhang wrote:
> > > If we remove this block, then where does the VS toolchain update happen?
> > 
> > Should be synced along with the whole build dir based on revision in this
file
> 
> So I see build/vs_toolchain.py exists and it gets updated when build/ gets
> updates. What about the actual VS toolchain that vs_tollchain.py is suppose to
> update? Wasn't running this hook what gets us the VS toolchain? Or am I
missing
> something?

oops, missed my morning coffee. Fixed.

[Lei Zhang, 2016-04-30 00:49:25]

lgtm

[Wei Li, 2016-04-30 03:02:18]

The CQ bit was checked by weili@chromium.org

[commit-bot: I haz the power, 2016-04-30 03:02:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1933843002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1933843002/20001

[commit-bot: I haz the power, 2016-04-30 03:14:57]

Description was changed from

==========
Use utilities from build directory instead of own copies

GYP and GN builds share some common utilities. GYP has three utilities
in its own directory which are also synced in build directory now.
We will use utilities from build directory instead of keeping our own
copies.

Compared to our own copies, utilities in build directory
are either same or newer. 
find_depot_tools.py is identical;
vs_toolchain.py and find_sdk.py have some minor updates.
==========

to

==========
Use utilities from build directory instead of own copies

GYP and GN builds share some common utilities. GYP has three utilities
in its own directory which are also synced in build directory now.
We will use utilities from build directory instead of keeping our own
copies.

Compared to our own copies, utilities in build directory
are either same or newer. 
find_depot_tools.py is identical;
vs_toolchain.py and find_sdk.py have some minor updates.

Committed:
https://pdfium.googlesource.com/pdfium/+/5593bb8573c1deb1c649083d51963348adf9...
==========

[commit-bot: I haz the power, 2016-04-30 03:14:58]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/5593bb8573c1deb1c649083d51963348adf9...