Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1933763002: Use null-aware operators to clean up the code (Closed)

Created:
4 years, 7 months ago by Brian Wilkerson
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Additional clean-up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -213 lines) Patch
M pkg/analyzer/lib/dart/ast/ast.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/file_system/file_system.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/file_system/memory_file_system.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/source/analysis_options_provider.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/source/path_filter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/context/cache.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/context/source.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/ast.dart View 9 chunks +9 lines, -16 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/utilities.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/dart/constant/evaluation.dart View 4 chunks +6 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/type.dart View 6 chunks +6 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/dart/resolver/inheritance_manager.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/dart/resolver/scope.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/element_resolver.dart View 3 chunks +4 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 3 chunks +9 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 8 chunks +8 lines, -17 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/java_core.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 26 chunks +51 lines, -92 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/source_io.dart View 4 chunks +5 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong/checker.dart View 3 chunks +6 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong/info.dart View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
There should be no semantic changes.
4 years, 7 months ago (2016-04-29 15:26:42 UTC) #2
scheglov
LGTM
4 years, 7 months ago (2016-04-29 15:30:01 UTC) #3
Brian Wilkerson
4 years, 7 months ago (2016-04-29 15:48:24 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
24d23680d12c9e75b027426e8319b9815b8590df (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698