Add ColorCodecSrc for testing/comparison on color corrected decodes

Add ColorCodecSrc for testing/comparison on color corrected decodes

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1933753002

Committed: https://skia.googlesource.com/skia/+/69deca8d1e57daec540f8a7f10d9c660b640b9a9

[msarett, 2016-04-29 15:09:17]

Description was changed from

==========
Add ColorCodecSrc for testing/comparison on color corrected decodes

BUG=skia:
==========

to

==========
Add ColorCodecSrc for testing/comparison on color corrected decodes

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-04-29 15:17:18]

msarett@google.com changed reviewers:
+ borenet@google.com, scroggo@google.com, stephana@google.com

[msarett, 2016-04-29 15:17:19]

I'm planning to add test images (with color profiles) to
gs://chromium-skia-gm/skimage/input/v4/colorspace/.

Stephan and Eric - Are you able to help so that our bots pass "--colorImages
/some/path/colorspace" to DM?  And then the outputs of these decodes will end up
on Gold?

[scroggo, 2016-04-29 15:36:51]

lgtm

https://codereview.chromium.org/1933753002/diff/1/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/1933753002/diff/1/dm/DM.cpp#newcode766
dm/DM.cpp:766: ColorCodecSrc* src = new ColorCodecSrc(path,
ColorCodecSrc::kBaseline_Mode);
Given that this is only two lines and only called in one place, I would
recommend inlining it.

[msarett, 2016-04-29 15:49:13]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 15:49:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1933753002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1933753002/20001

[commit-bot: I haz the power, 2016-04-29 16:02:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 16:02:46]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-04-29 16:37:24]

https://codereview.chromium.org/1933753002/diff/1/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/1933753002/diff/1/dm/DM.cpp#newcode766
dm/DM.cpp:766: ColorCodecSrc* src = new ColorCodecSrc(path,
ColorCodecSrc::kBaseline_Mode);
On 2016/04/29 15:36:51, scroggo wrote:
> Given that this is only two lines and only called in one place, I would
> recommend inlining it.

Done.

[msarett, 2016-04-29 16:37:34]

The CQ bit was checked by msarett@google.com

[msarett, 2016-04-29 16:37:35]

The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com
Link to the patchset: https://codereview.chromium.org/1933753002/#ps20001
(title: "Response to comments")

[commit-bot: I haz the power, 2016-04-29 16:37:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1933753002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1933753002/20001

[commit-bot: I haz the power, 2016-04-29 16:38:43]

Description was changed from

==========
Add ColorCodecSrc for testing/comparison on color corrected decodes

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add ColorCodecSrc for testing/comparison on color corrected decodes

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/69deca8d1e57daec540f8a7f10d9c660b640b9a9
==========

[commit-bot: I haz the power, 2016-04-29 16:38:43]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/69deca8d1e57daec540f8a7f10d9c660b640b9a9

[borenet, 2016-04-29 17:32:53]

On 2016/04/29 15:17:19, msarett wrote:
> I'm planning to add test images (with color profiles) to
> gs://chromium-skia-gm/skimage/input/v4/colorspace/.
> 
> Stephan and Eric - Are you able to help so that our bots pass "--colorImages
> /some/path/colorspace" to DM?  And then the outputs of these decodes will end
up
> on Gold?

A few questions:
1. This is for all bots?
2. "colorspace" will be a sibling of "dm" and "nanobench" in GS?

[msarett, 2016-04-29 17:40:52]

On 2016/04/29 17:32:53, borenet wrote:
> On 2016/04/29 15:17:19, msarett wrote:
> > I'm planning to add test images (with color profiles) to
> > gs://chromium-skia-gm/skimage/input/v4/colorspace/.
> > 
> > Stephan and Eric - Are you able to help so that our bots pass "--colorImages
> > /some/path/colorspace" to DM?  And then the outputs of these decodes will
end
> up
> > on Gold?
> 
> A few questions:
> 1. This is for all bots?

Yes I think that's best.

> 2. "colorspace" will be a sibling of "dm" and "nanobench" in GS?

Yes I think it should be its own folder.  We do a lot of tests on "dm" images,
so adding a bunch of images to the dm folder would probably slow down the bots
quite a bit (and the results wouldn't be interesting).  Also it's nice to
separate the images that actually have color profiles so the "colorspace" tests
aren't testing a bunch of no-op color corrections.

[msarett, 2016-05-03 20:32:42]

On 2016/04/29 17:40:52, msarett wrote:
> On 2016/04/29 17:32:53, borenet wrote:
> > On 2016/04/29 15:17:19, msarett wrote:
> > > I'm planning to add test images (with color profiles) to
> > > gs://chromium-skia-gm/skimage/input/v4/colorspace/.
> > > 
> > > Stephan and Eric - Are you able to help so that our bots pass
"--colorImages
> > > /some/path/colorspace" to DM?  And then the outputs of these decodes will
> end
> > up
> > > on Gold?
> > 
> > A few questions:
> > 1. This is for all bots?
> 
> Yes I think that's best.
> 
> > 2. "colorspace" will be a sibling of "dm" and "nanobench" in GS?
> 
> Yes I think it should be its own folder.  We do a lot of tests on "dm" images,
> so adding a bunch of images to the dm folder would probably slow down the bots
> quite a bit (and the results wouldn't be interesting).  Also it's nice to
> separate the images that actually have color profiles so the "colorspace"
tests
> aren't testing a bunch of no-op color corrections.

Eric, does this seem reasonable?

[borenet, 2016-05-04 12:11:19]

On 2016/05/03 20:32:42, msarett wrote:
> On 2016/04/29 17:40:52, msarett wrote:
> > On 2016/04/29 17:32:53, borenet wrote:
> > > On 2016/04/29 15:17:19, msarett wrote:
> > > > I'm planning to add test images (with color profiles) to
> > > > gs://chromium-skia-gm/skimage/input/v4/colorspace/.
> > > > 
> > > > Stephan and Eric - Are you able to help so that our bots pass
> "--colorImages
> > > > /some/path/colorspace" to DM?  And then the outputs of these decodes
will
> > end
> > > up
> > > > on Gold?
> > > 
> > > A few questions:
> > > 1. This is for all bots?
> > 
> > Yes I think that's best.
> > 
> > > 2. "colorspace" will be a sibling of "dm" and "nanobench" in GS?
> > 
> > Yes I think it should be its own folder.  We do a lot of tests on "dm"
images,
> > so adding a bunch of images to the dm folder would probably slow down the
bots
> > quite a bit (and the results wouldn't be interesting).  Also it's nice to
> > separate the images that actually have color profiles so the "colorspace"
> tests
> > aren't testing a bunch of no-op color corrections.
> 
> Eric, does this seem reasonable?

Yes, that sounds reasonable. I uploaded a CL and have written a couple of
concerns there: https://codereview.chromium.org/1951843002/