Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 1933733002: Revert of Adjust tolerance to fix bezier glitches issue (Closed)

Created:
4 years, 7 months ago by jvanverth1
Modified:
4 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Adjust tolerance to fix bezier glitches issue (patchset #1 id:1 of https://codereview.chromium.org/1926063002/ ) Reason for revert: This is causing undesirable image failures in a large number of Skia GMs. Original issue's description: > Adjust tolerance to fix bezier glitches issue > > In a previous CL: https://codereview.chromium.org/1126793003, the value > of gDegenerateToLineTol was changed from 1.0 to 0.25 which caused the > bezier glitches. > > This CL changes the value to SK_ScalarRoot2Over2, with this change the > bezier curve looks fine, and the result of the layout tests pointed out > in this bug: https://bugs.chromium.org/p/chromium/issues/detail?id=472847 > is also reasonable. > > BUG=605439 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1926063002 > > Committed: https://skia.googlesource.com/skia/+/45a6f49ef9ff276e08025d0d2ba6a821a96d3f34 TBR=robertphillips@google.com,xidachen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=605439 Committed: https://skia.googlesource.com/skia/+/cfeb85fa6a2fcebc0c54f08f313058bae7258e63

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/gpu/batches/GrAAHairLinePathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
jvanverth1
Created Revert of Adjust tolerance to fix bezier glitches issue
4 years, 7 months ago (2016-04-29 14:38:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933733002/1
4 years, 7 months ago (2016-04-29 14:38:05 UTC) #2
commit-bot: I haz the power
4 years, 7 months ago (2016-04-29 14:38:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cfeb85fa6a2fcebc0c54f08f313058bae7258e63

Powered by Google App Engine
This is Rietveld 408576698