Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Issue 1933643002: Move markLinesDirtyInBlockRange() from LayoutBlock to LayoutBlockFlow. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move markLinesDirtyInBlockRange() from LayoutBlock to LayoutBlockFlow. And put the implementation in LayoutBlockFlowLine.cpp. BUG=302024 Committed: https://crrev.com/cef50e052b7922e6d5061aca865977758daa5888 Cr-Commit-Position: refs/heads/master@{#390724}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -20 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mstensho (USE GERRIT)
I have some issues in the sweet spot intersected by line layout, floats and pagination, ...
4 years, 7 months ago (2016-04-29 09:10:42 UTC) #2
leviw_travelin_and_unemployed
lgtm
4 years, 7 months ago (2016-04-29 19:49:18 UTC) #5
leviw_travelin_and_unemployed
lgtm
4 years, 7 months ago (2016-04-29 19:49:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933643002/1
4 years, 7 months ago (2016-04-29 19:49:42 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 19:54:26 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:28:01 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cef50e052b7922e6d5061aca865977758daa5888
Cr-Commit-Position: refs/heads/master@{#390724}

Powered by Google App Engine
This is Rietveld 408576698