Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1933633002: Remove replacedChildren vector from inline layout. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove replacedChildren vector from inline layout. This vector was populated during child walking and consumed right after the walk. There should be no reason not to just process the objects right away. Committed: https://crrev.com/b56f9c5e4843967306e2fa249d7228394b3de930 Cr-Commit-Position: refs/heads/master@{#390765}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp View 3 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
Hmm... the bots agree with me, at least.
4 years, 7 months ago (2016-04-29 12:17:59 UTC) #2
leviw_travelin_and_unemployed
lgtm It was added in https://chromium.googlesource.com/chromium/src/+/70f89cbde851b0d568e7d9235ad5a4921f398813 (And reviewed by me! Hooray!) If replaced-last-line-layout.html passes, I'm ...
4 years, 7 months ago (2016-04-29 21:21:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933633002/1
4 years, 7 months ago (2016-04-29 21:21:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 21:27:01 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:29:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b56f9c5e4843967306e2fa249d7228394b3de930
Cr-Commit-Position: refs/heads/master@{#390765}

Powered by Google App Engine
This is Rietveld 408576698