Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1933583002: Revert of Add PDFium build_overrides (Closed)

Created:
4 years, 7 months ago by dsinclair
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add PDFium build_overrides (patchset #5 id:100001 of https://codereview.chromium.org/1923343002/ ) Reason for revert: Broke fuzzer bots. Original issue's description: > Add PDFium build_overrides > > This CL adds the build override settings so we can enable XFA in GN builds > in the future. > > BUG=chromium:62400 TBR=thakis@chromium.org,tsepez@chromium.org,thestig@chromium.org,dpranke@chromium.org,aizatsky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:62400 Committed: https://crrev.com/e43a2442a5e5e1000021caf9f692b69208e1e53c Cr-Commit-Position: refs/heads/master@{#390577}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -22 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
D build_overrides/pdfium.gni View 1 chunk +0 lines, -19 lines 0 comments Download
M pdf/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M pdf/pdfium/fuzzers/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
dsinclair
Created Revert of Add PDFium build_overrides
4 years, 7 months ago (2016-04-29 02:25:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933583002/1
4 years, 7 months ago (2016-04-29 02:25:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 02:25:42 UTC) #3
Dirk Pranke
lgtm
4 years, 7 months ago (2016-04-29 02:27:34 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:23:54 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e43a2442a5e5e1000021caf9f692b69208e1e53c
Cr-Commit-Position: refs/heads/master@{#390577}

Powered by Google App Engine
This is Rietveld 408576698