third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp - Issue 1933573002: [DevTools] Remove last bits of logic from v8 agent wrappers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

Issue 1933573002: [DevTools] Remove last bits of logic from v8 agent wrappers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1913283003

Patch Set: rebased, fixed uninitialized variable Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

index dac95be11b5d65e70751095b81d9f729658e411c..7b46e8a2581e5b3aa075c9750c87312735b817de 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

@@ -99,6 +99,8 @@ void V8RuntimeAgentImpl::evaluate(

if (doNotPauseOnExceptionsAndMuteConsole.fromMaybe(false))

scope.ignoreExceptionsAndMuteConsole();

+ if (userGesture.fromMaybe(false))

+ scope.pretendUserGesture();

if (includeCommandLineAPI.fromMaybe(false) && !scope.installCommandLineAPI())

return;

@@ -161,6 +163,8 @@ void V8RuntimeAgentImpl::callFunctionOn(ErrorString* errorString,

if (doNotPauseOnExceptionsAndMuteConsole.fromMaybe(false))

scope.ignoreExceptionsAndMuteConsole();

+ if (userGesture.fromMaybe(false))

+ scope.pretendUserGesture();

v8::MaybeLocal<v8::Value> maybeFunctionValue = m_debugger->compileAndRunInternalScript(scope.context(), toV8String(m_debugger->isolate(), "(" + expression + ")"));

// Re-initialize after running client's code, as it could have destroyed context or session.

@@ -253,7 +257,7 @@ void V8RuntimeAgentImpl::releaseObjectGroup(ErrorString*, const String16& object

void V8RuntimeAgentImpl::run(ErrorString* errorString)

{

- *errorString = "Not paused";

+ m_session->client()->resumeStartup();

}

void V8RuntimeAgentImpl::setCustomObjectFormatterEnabled(ErrorString*, bool enabled)