third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp - Issue 1933573002: [DevTools] Remove last bits of logic from v8 agent wrappers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp

Issue 1933573002: [DevTools] Remove last bits of logic from v8 agent wrappers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1913283003

Patch Set: rebased, fixed uninitialized variable Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp

index 40192f0f85a710830b55452c893d22427646172a..3bb1e05c19a1dfabb642250f3a76be315c989fed 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp

@@ -243,6 +243,7 @@ void V8ProfilerAgentImpl::start(ErrorString* error)

m_frontendInitiatedProfileId = nextProfileId();

startProfiling(m_frontendInitiatedProfileId);

m_state->setBoolean(ProfilerAgentState::userInitiatedProfiling, true);

+ m_session->client()->profilingStarted();

}

void V8ProfilerAgentImpl::stop(ErrorString* errorString, OwnPtr<protocol::Profiler::CPUProfile>* profile)

@@ -261,6 +262,7 @@ void V8ProfilerAgentImpl::stop(ErrorString* errorString, OwnPtr<protocol::Profil

}

m_frontendInitiatedProfileId = String16();

m_state->setBoolean(ProfilerAgentState::userInitiatedProfiling, false);

+ m_session->client()->profilingStopped();

}

String16 V8ProfilerAgentImpl::nextProfileId()