Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1933533002: Enable dcheck on the GPU waterfall bots. (Closed)

Created:
4 years, 7 months ago by Dirk Pranke
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable dcheck on the GPU waterfall bots. Since we can't afford to run the debug versions of the tests on the GPU waterfall bots, we want to run release builds w/ dchecks enabled. Note that we enable dchecks here, but the dcheck chromium config is *not* applied on the build-side recipes. We do that intentionally so that a given trybot can merge the configs from both the main waterfall bots and the gpu bots (which otherwise would have conflicting configs), but this may be confusing. The right fix here is to do away with as many recipe-side configs that set GYP_DEFINES as possible, since the real settings are governed by MB, src-side. R=kbr@chromium.org, phajdan.jr@chromium.org BUG=606700 Committed: https://crrev.com/fe42ebe1aa800787216d69be07b52411076592dd Cr-Commit-Position: refs/heads/master@{#390828}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -63 lines) Patch
M tools/mb/mb_config.pyl View 1 8 chunks +54 lines, -63 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Dirk Pranke
4 years, 7 months ago (2016-04-28 23:44:45 UTC) #1
Ken Russell (switch to Gerrit)
Thanks for making this change. LGTM
4 years, 7 months ago (2016-04-29 09:57:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933533002/1
4 years, 7 months ago (2016-04-29 16:41:41 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/167884) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-04-29 16:43:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933533002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933533002/20001
4 years, 7 months ago (2016-04-30 00:12:33 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-30 01:10:22 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:30:46 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fe42ebe1aa800787216d69be07b52411076592dd
Cr-Commit-Position: refs/heads/master@{#390828}

Powered by Google App Engine
This is Rietveld 408576698