Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1933513003: [wasm] Add a flag to output the generated code size (Closed)

Created:
4 years, 7 months ago by Clemens Hammacher
Modified:
4 years, 7 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Add a flag to output the generated code size The output is once per module, and includes the size of relocation information. R=titzer@chromium.org Committed: https://crrev.com/9763806ae60ea63387e56d5d8cf989bba09873df Cr-Commit-Position: refs/heads/master@{#35900}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 1

Patch Set 3 : add TODO and switch to uint32_t #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M src/flag-definitions.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 2 5 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Clemens Hammacher
4 years, 7 months ago (2016-04-29 09:45:53 UTC) #1
titzer
lgtm https://codereview.chromium.org/1933513003/diff/20001/src/wasm/wasm-module.cc File src/wasm/wasm-module.cc (right): https://codereview.chromium.org/1933513003/diff/20001/src/wasm/wasm-module.cc#newcode416 src/wasm/wasm-module.cc:416: // If FLAG_print_wasm_code_size is set, this aggregates the ...
4 years, 7 months ago (2016-04-29 09:51:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933513003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933513003/40001
4 years, 7 months ago (2016-04-29 10:45:37 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-04-29 10:50:16 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:03:37 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9763806ae60ea63387e56d5d8cf989bba09873df
Cr-Commit-Position: refs/heads/master@{#35900}

Powered by Google App Engine
This is Rietveld 408576698