Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1933503002:
Post-mortem fix merged into V8 5.0 branch (Closed)
|
Created:
4 years, 7 months ago by fedor.indutny Modified:
4 years, 7 months ago Reviewers:
Michael Hablich CC:
v8-reviews_googlegroups.com, ulan Base URL:
https://chromium.googlesource.com/v8/v8.git@5.0 Target Ref:
refs/pending/branch-heads/5.0 Project:
v8 Visibility:
Public. |
DescriptionPost-mortem fix merged into V8 5.0 branch
I have merged a post-mortem tooling improvement 8eda85d into the 5.0
branch (the version used in node.js v6).
Version 5.0.71.41 (cherry-pick)
Postmortem: export DATA_CONSTANT
R=hablich
BUG=v8:4975
NOTRY=true
NOPRESUBMIT=true
Patch Set 1 #
Messages
Total messages: 21 (9 generated)
Hopefully this CL is better!
On 2016/04/28 21:57:43, fedor.indutny wrote: > Hopefully this CL is better Lgtm but please add a tracking bug. If there is none, create one and link it in this CL.
Description was changed from ========== Post-mortem fix merged into V8 5.0 branch I have merged a post-mortem tooling improvement 8eda85d into the 5.0 branch (the version used in node.js v6). Version 5.0.71.41 (cherry-pick) Postmortem: export DATA_CONSTANT R=hablich BUG= ========== to ========== Post-mortem fix merged into V8 5.0 branch I have merged a post-mortem tooling improvement 8eda85d into the 5.0 branch (the version used in node.js v6). Version 5.0.71.41 (cherry-pick) Postmortem: export DATA_CONSTANT R=hablich BUG=4975 ==========
Description was changed from ========== Post-mortem fix merged into V8 5.0 branch I have merged a post-mortem tooling improvement 8eda85d into the 5.0 branch (the version used in node.js v6). Version 5.0.71.41 (cherry-pick) Postmortem: export DATA_CONSTANT R=hablich BUG=4975 ========== to ========== Post-mortem fix merged into V8 5.0 branch I have merged a post-mortem tooling improvement 8eda85d into the 5.0 branch (the version used in node.js v6). Version 5.0.71.41 (cherry-pick) Postmortem: export DATA_CONSTANT R=hablich BUG=https://bugs.chromium.org/p/v8/issues/detail?id=4975 ==========
Description was changed from ========== Post-mortem fix merged into V8 5.0 branch I have merged a post-mortem tooling improvement 8eda85d into the 5.0 branch (the version used in node.js v6). Version 5.0.71.41 (cherry-pick) Postmortem: export DATA_CONSTANT R=hablich BUG=https://bugs.chromium.org/p/v8/issues/detail?id=4975 ========== to ========== Post-mortem fix merged into V8 5.0 branch I have merged a post-mortem tooling improvement 8eda85d into the 5.0 branch (the version used in node.js v6). Version 5.0.71.41 (cherry-pick) Postmortem: export DATA_CONSTANT R=hablich BUG=v8/4975 ==========
Thanks, how do I link this https://bugs.chromium.org/p/v8/issues/detail?id=4975 ?
On 2016/04/29 05:26:07, fedor.indutny wrote: > Thanks, how do I link this https://bugs.chromium.org/p/v8/issues/detail?id=4975 > ? BUG=v8:4975
Description was changed from ========== Post-mortem fix merged into V8 5.0 branch I have merged a post-mortem tooling improvement 8eda85d into the 5.0 branch (the version used in node.js v6). Version 5.0.71.41 (cherry-pick) Postmortem: export DATA_CONSTANT R=hablich BUG=v8/4975 ========== to ========== Post-mortem fix merged into V8 5.0 branch I have merged a post-mortem tooling improvement 8eda85d into the 5.0 branch (the version used in node.js v6). Version 5.0.71.41 (cherry-pick) Postmortem: export DATA_CONSTANT R=hablich BUG=v8:4975 ==========
Thank you!
The CQ bit was checked by fedor@indutny.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933503002/1
The CQ bit was unchecked by commit-bot@chromium.org
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
Mmm... Do I need to do something special to land this? :)
On 2016/04/29 05:57:31, fedor.indutny wrote: > Mmm... Do I need to do something special to land this? :) "CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them" ==> just add NOTRY=true NOPRESUBMIT=true to the CL description.
Description was changed from ========== Post-mortem fix merged into V8 5.0 branch I have merged a post-mortem tooling improvement 8eda85d into the 5.0 branch (the version used in node.js v6). Version 5.0.71.41 (cherry-pick) Postmortem: export DATA_CONSTANT R=hablich BUG=v8:4975 ========== to ========== Post-mortem fix merged into V8 5.0 branch I have merged a post-mortem tooling improvement 8eda85d into the 5.0 branch (the version used in node.js v6). Version 5.0.71.41 (cherry-pick) Postmortem: export DATA_CONSTANT R=hablich BUG=v8:4975 NOTRY=true NOPRESUBMIT=true ==========
The CQ bit was checked by fedor@indutny.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933503002/1
Message was sent while issue was closed.
Description was changed from ========== Post-mortem fix merged into V8 5.0 branch I have merged a post-mortem tooling improvement 8eda85d into the 5.0 branch (the version used in node.js v6). Version 5.0.71.41 (cherry-pick) Postmortem: export DATA_CONSTANT R=hablich BUG=v8:4975 NOTRY=true NOPRESUBMIT=true ========== to ========== Post-mortem fix merged into V8 5.0 branch I have merged a post-mortem tooling improvement 8eda85d into the 5.0 branch (the version used in node.js v6). Version 5.0.71.41 (cherry-pick) Postmortem: export DATA_CONSTANT R=hablich BUG=v8:4975 NOTRY=true NOPRESUBMIT=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
