Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Issue 1933473002: Added more strict checks for fence sync counters. (Closed)

Created:
4 years, 7 months ago by David Yen
Modified:
4 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added more strict checks for fence sync counters. R=piman@chromium.org BUG=606112 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/4d075d2b7a85c4c9c5fa8a0d5158f2e74f2d5b97 Cr-Commit-Position: refs/heads/master@{#390569}

Patch Set 1 #

Patch Set 2 : Added thread_checker for lockless case #

Patch Set 3 : Also enforce image release count on server side. #

Patch Set 4 : Add thread_checker header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M gpu/ipc/client/command_buffer_proxy_impl.h View 1 2 3 3 chunks +9 lines, -1 line 0 comments Download
M gpu/ipc/client/command_buffer_proxy_impl.cc View 2 chunks +4 lines, -1 line 0 comments Download
M gpu/ipc/service/gpu_command_buffer_stub.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
David Yen
4 years, 7 months ago (2016-04-28 21:22:34 UTC) #1
David Yen
This too didn't trigger any assertions locally, but I'll just leave them there in case ...
4 years, 7 months ago (2016-04-28 21:40:24 UTC) #3
David Yen
On 2016/04/28 21:40:24, David Yen wrote: > This too didn't trigger any assertions locally, but ...
4 years, 7 months ago (2016-04-28 21:41:46 UTC) #4
piman
lgtm
4 years, 7 months ago (2016-04-28 23:29:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933473002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933473002/60001
4 years, 7 months ago (2016-04-29 00:37:42 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-04-29 01:54:07 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:23:39 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4d075d2b7a85c4c9c5fa8a0d5158f2e74f2d5b97
Cr-Commit-Position: refs/heads/master@{#390569}

Powered by Google App Engine
This is Rietveld 408576698