Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1933453002: Get rid of pre-focus call which was used for URL fading only. (Closed)

Created:
4 years, 7 months ago by Maria
Modified:
4 years, 7 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of pre-focus call which was used for URL fading only. This was causing us to call autocomplete with the URL as the input text. BUG=604076 Committed: https://crrev.com/0d5075cf3b4263ca3ff59206ac4e57b3d25fb7ae Cr-Commit-Position: refs/heads/master@{#390516}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Maria
Not removing from the interface because I am worried about branch calls being different. Will ...
4 years, 7 months ago (2016-04-28 21:12:09 UTC) #2
Ted C
lgtm
4 years, 7 months ago (2016-04-28 21:23:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933453002/1
4 years, 7 months ago (2016-04-28 21:41:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 22:41:12 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:22:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d5075cf3b4263ca3ff59206ac4e57b3d25fb7ae
Cr-Commit-Position: refs/heads/master@{#390516}

Powered by Google App Engine
This is Rietveld 408576698